[PR #260] [MERGED] Fix `is_playable` always being `None` #351

New issue

Closed

opened 2026-02-27 20:24:22 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 20:24:22 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/ramsayleung/rspotify/pull/260
Author: @marioortizmanero
Created: 9/25/2021
Status: ✅ Merged
Merged: 9/28/2021
Merged by: @ramsayleung

Base: percent-search ← Head: is-playable-tests

📝 Commits (3)

d80ab80 Fix current_user_saved_{tracks,albums}
fc56139 Update changelog
ef3a000 Fix examples and tests

📊 Changes

6 files changed (+35 additions, -20 deletions)

View changed files

📝 CHANGELOG.md (+1 -0)
📝 examples/pagination_async.rs (+2 -2)
📝 examples/pagination_manual.rs (+1 -1)
📝 examples/pagination_sync.rs (+1 -1)
📝 src/clients/oauth.rs (+18 -4)
📝 tests/test_with_oauth.rs (+12 -12)

📄 Description

Description

As #190 explains, is_playable was always None because the market parameter was missing in these endpoints.

I suggest merging #259 first, as I wrote this over that branch by mistake.

Motivation and Context

Closes #190

Dependencies

None

Type of change

Please delete options that are not relevant.

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update

How Has This Been Tested?

Check out the test I modified. Can be ran with, for example:

$ cargo test --no-default-features --features=client-ureq,ureq-rustls-tls -- --ignored test_current_user_saved_tracks_add

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/ramsayleung/rspotify/pull/260 **Author:** [@marioortizmanero](https://github.com/marioortizmanero) **Created:** 9/25/2021 **Status:** ✅ Merged **Merged:** 9/28/2021 **Merged by:** [@ramsayleung](https://github.com/ramsayleung) **Base:** `percent-search` ← **Head:** `is-playable-tests` --- ### 📝 Commits (3) - [`d80ab80`](https://github.com/ramsayleung/rspotify/commit/d80ab80d797344c8aa722f704525ad68dcfc4576) Fix `current_user_saved_{tracks,albums}` - [`fc56139`](https://github.com/ramsayleung/rspotify/commit/fc561395a9e543e4fb1468d229c798994b6a9ae9) Update changelog - [`ef3a000`](https://github.com/ramsayleung/rspotify/commit/ef3a000ce02679df0d1f56c1daf3596915332cee) Fix examples and tests ### 📊 Changes **6 files changed** (+35 additions, -20 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELOG.md` (+1 -0) 📝 `examples/pagination_async.rs` (+2 -2) 📝 `examples/pagination_manual.rs` (+1 -1) 📝 `examples/pagination_sync.rs` (+1 -1) 📝 `src/clients/oauth.rs` (+18 -4) 📝 `tests/test_with_oauth.rs` (+12 -12) </details> ### 📄 Description ## Description As #190 explains, `is_playable` was always `None` because the `market` parameter was missing in these endpoints. I suggest merging #259 first, as I wrote this over that branch by mistake. ## Motivation and Context Closes #190 ## Dependencies None ## Type of change Please delete options that are not relevant. - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [x] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [x] This change requires a documentation update ## How Has This Been Tested? Check out the test I modified. Can be ran with, for example: ``` $ cargo test --no-default-features --features=client-ureq,ureq-rustls-tls -- --ignored test_current_user_saved_tracks_add ``` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>