[PR #256] [MERGED] Added missing parameter from current_user_recently_played() #347

New issue

Closed

opened 2026-02-27 20:24:21 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 20:24:21 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/ramsayleung/rspotify/pull/256
Author: @marioortizmanero
Created: 9/25/2021
Status: ✅ Merged
Merged: 9/26/2021
Merged by: @ramsayleung

Base: master ← Head: recently_played_after_v2

📝 Commits (4)

64772a0 Added missing parameter
8355509 Update CHANGELOG
3cde10c Use DateTime instead of raw timestamp
b2e148b Use milliseconds for timestamp

📊 Changes

4 files changed (+29 additions, -5 deletions)

View changed files

📝 CHANGELOG.md (+1 -0)
📝 rspotify-model/src/enums/misc.rs (+10 -0)
📝 src/clients/oauth.rs (+14 -2)
📝 tests/test_with_oauth.rs (+4 -3)

📄 Description

Credits to @hellbound22 for the original PR: #198. I've rewritten it for the updated rspotify and applied the review comments.

Description

Fix the implementation of current_user_recently_played() with the missing parameters.

Motivation and Context

The Spotify web api of current_user_recently_played() has the parameters before and after that are not implemented in this crate.

Dependencies

None

Type of change

Please delete options that are not relevant.

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update

How Has This Been Tested?

The OAuth2 test passes when adding the None as the second parameter. Might have to write another test when the Option is Some(_)

Also, been using this with success in a project of mine.

Please also list any relevant details for your test configuration

test_with_oauth::test_current_user_recently_played()

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/ramsayleung/rspotify/pull/256 **Author:** [@marioortizmanero](https://github.com/marioortizmanero) **Created:** 9/25/2021 **Status:** ✅ Merged **Merged:** 9/26/2021 **Merged by:** [@ramsayleung](https://github.com/ramsayleung) **Base:** `master` ← **Head:** `recently_played_after_v2` --- ### 📝 Commits (4) - [`64772a0`](https://github.com/ramsayleung/rspotify/commit/64772a08192a9cc1800daac2f52cc830a0111111) Added missing parameter - [`8355509`](https://github.com/ramsayleung/rspotify/commit/835550981e05594fb18c237acb4cd9f18cb310ec) Update CHANGELOG - [`3cde10c`](https://github.com/ramsayleung/rspotify/commit/3cde10c954f5826acd37ef17406d71a3f392419b) Use `DateTime` instead of raw timestamp - [`b2e148b`](https://github.com/ramsayleung/rspotify/commit/b2e148bff33bd74f35f9fcd2f7b354f93ef3fcb1) Use milliseconds for timestamp ### 📊 Changes **4 files changed** (+29 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELOG.md` (+1 -0) 📝 `rspotify-model/src/enums/misc.rs` (+10 -0) 📝 `src/clients/oauth.rs` (+14 -2) 📝 `tests/test_with_oauth.rs` (+4 -3) </details> ### 📄 Description Credits to @hellbound22 for the original PR: #198. I've rewritten it for the updated `rspotify` and applied the review comments. ## Description Fix the implementation of ```current_user_recently_played()``` with the missing parameters. ## Motivation and Context The Spotify web api of ```current_user_recently_played()``` has the parameters ```before``` and ```after``` that are not implemented in this crate. ## Dependencies None ## Type of change Please delete options that are not relevant. - [x] Bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds functionality) - [x] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [x] This change requires a documentation update ## How Has This Been Tested? The OAuth2 test passes when adding the ```None``` as the second parameter. Might have to write another test when the Option is ```Some(_)``` Also, been using this with success in a project of mine. Please also list any relevant details for your test configuration - [x] ```test_with_oauth::test_current_user_recently_played()``` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>