[PR #255] [CLOSED] Fix refreshing token #345

New issue

Closed

opened 2026-02-27 20:24:21 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 20:24:21 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/ramsayleung/rspotify/pull/255
Author: @marioortizmanero
Created: 9/25/2021
Status: ❌ Closed

Base: ramsay_support_refresh_token ← Head: fix-refresh-token

📝 Commits (10+)

f887e93 Use Github Action to automatically publish crate to crate.io
c2046c7 Add UnknownId and some tests
d5d2812 Proper docs thanks to reworked macro
5a52393 Module-level documentation
1ab8ad1 Now with an example!
3b66b9a Stuck fighting compiler error about Deserialize
5d459f4 First draft with newtype
ea435db The compiler hates me
ce0a860 Mixing Attempt #1 and Attempt #2
bbf0cc2 Almost working now

📊 Changes

44 files changed (+1406 additions, -1142 deletions)

View changed files

➕ .github/workflows/publish.yaml (+29 -0)
📝 CHANGELOG.md (+7 -5)
📝 Cargo.toml (+13 -21)
📝 examples/client_creds.rs (+4 -4)
📝 examples/oauth_tokens.rs (+1 -1)
📝 examples/ureq/threading.rs (+7 -6)
📝 examples/with_auto_reauth.rs (+3 -1)
📝 examples/with_refresh_token.rs (+7 -7)
📝 rspotify-http/Cargo.toml (+9 -14)
📝 rspotify-macros/Cargo.toml (+1 -1)
📝 rspotify-model/Cargo.toml (+5 -6)
📝 rspotify-model/src/album.rs (+14 -14)
📝 rspotify-model/src/artist.rs (+4 -11)
📝 rspotify-model/src/audio.rs (+7 -5)
➕ rspotify-model/src/auth.rs (+89 -0)
📝 rspotify-model/src/category.rs (+2 -2)
📝 rspotify-model/src/context.rs (+7 -5)
➕ rspotify-model/src/custom_serde.rs (+230 -0)
📝 rspotify-model/src/error.rs (+15 -1)
📝 rspotify-model/src/idtypes.rs (+447 -217)

...and 24 more files

📄 Description

Description

This fixes #224 by creating a wrapper for Mutex so that it's the same for both sync and async programming, similarly to how pagination works.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/ramsayleung/rspotify/pull/255 **Author:** [@marioortizmanero](https://github.com/marioortizmanero) **Created:** 9/25/2021 **Status:** ❌ Closed **Base:** `ramsay_support_refresh_token` ← **Head:** `fix-refresh-token` --- ### 📝 Commits (10+) - [`f887e93`](https://github.com/ramsayleung/rspotify/commit/f887e930c6cffe770185559a6e015576d834ca37) Use Github Action to automatically publish crate to crate.io - [`c2046c7`](https://github.com/ramsayleung/rspotify/commit/c2046c71a0408660ed6b49ea2a2914264865f388) Add UnknownId and some tests - [`d5d2812`](https://github.com/ramsayleung/rspotify/commit/d5d281249c73227870a4b487317ecbe89b4c9993) Proper docs thanks to reworked macro - [`5a52393`](https://github.com/ramsayleung/rspotify/commit/5a52393c384239a5b525505ccf75dd91e8f08806) Module-level documentation - [`1ab8ad1`](https://github.com/ramsayleung/rspotify/commit/1ab8ad1fcb82464a647728b8ed3b4d4b36b45f43) Now with an example! - [`3b66b9a`](https://github.com/ramsayleung/rspotify/commit/3b66b9a7c8a46c2cdb620ae68d7b88f15c3be6b2) Stuck fighting compiler error about Deserialize - [`5d459f4`](https://github.com/ramsayleung/rspotify/commit/5d459f47b543e354d1fdb0911b7654749db94fc6) First draft with newtype - [`ea435db`](https://github.com/ramsayleung/rspotify/commit/ea435db5e9d13bb1c5497842b3b56c9a9ce719d6) The compiler hates me - [`ce0a860`](https://github.com/ramsayleung/rspotify/commit/ce0a860c0e9292d9c752889bc943bee75fc86dea) Mixing Attempt #1 and Attempt #2 - [`bbf0cc2`](https://github.com/ramsayleung/rspotify/commit/bbf0cc22138230749a6ec1d04bea98155891a16e) Almost working now ### 📊 Changes **44 files changed** (+1406 additions, -1142 deletions) <details> <summary>View changed files</summary> ➕ `.github/workflows/publish.yaml` (+29 -0) 📝 `CHANGELOG.md` (+7 -5) 📝 `Cargo.toml` (+13 -21) 📝 `examples/client_creds.rs` (+4 -4) 📝 `examples/oauth_tokens.rs` (+1 -1) 📝 `examples/ureq/threading.rs` (+7 -6) 📝 `examples/with_auto_reauth.rs` (+3 -1) 📝 `examples/with_refresh_token.rs` (+7 -7) 📝 `rspotify-http/Cargo.toml` (+9 -14) 📝 `rspotify-macros/Cargo.toml` (+1 -1) 📝 `rspotify-model/Cargo.toml` (+5 -6) 📝 `rspotify-model/src/album.rs` (+14 -14) 📝 `rspotify-model/src/artist.rs` (+4 -11) 📝 `rspotify-model/src/audio.rs` (+7 -5) ➕ `rspotify-model/src/auth.rs` (+89 -0) 📝 `rspotify-model/src/category.rs` (+2 -2) 📝 `rspotify-model/src/context.rs` (+7 -5) ➕ `rspotify-model/src/custom_serde.rs` (+230 -0) 📝 `rspotify-model/src/error.rs` (+15 -1) 📝 `rspotify-model/src/idtypes.rs` (+447 -217) _...and 24 more files_ </details> ### 📄 Description ## Description This fixes #224 by creating a wrapper for `Mutex` so that it's the same for both sync and async programming, similarly to how pagination works. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>