[PR #249] [MERGED] Simplify recommendations endpoint #340

New issue

Closed

opened 2026-02-27 20:24:20 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 20:24:20 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/ramsayleung/rspotify/pull/249
Author: @marioortizmanero
Created: 8/31/2021
Status: ✅ Merged
Merged: 9/2/2021
Merged by: @ramsayleung

Base: master ← Head: simplify-recommendations

📝 Commits (4)

a3d14dc Simplify recommendations
0c767e7 Fix CI, generics for HashMap, ready 4 review
0b2c479 Serialize attributes
5d228ab update changelog

📊 Changes

4 files changed (+130 additions, -49 deletions)

View changed files

📝 CHANGELOG.md (+1 -0)
📝 rspotify-model/src/recommend.rs (+105 -0)
📝 src/clients/base.rs (+15 -39)
📝 tests/test_with_oauth.rs (+9 -10)

📄 Description

Description

The recommendations endpoint was very messy and had a long-standing TODO item. I've simplified it so that it just takes a map with the attributes that are directly appended to the query payload.

Dependencies

None

Type of change

Please delete options that are not relevant.

Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

The test_recommendations endpoint

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/ramsayleung/rspotify/pull/249 **Author:** [@marioortizmanero](https://github.com/marioortizmanero) **Created:** 8/31/2021 **Status:** ✅ Merged **Merged:** 9/2/2021 **Merged by:** [@ramsayleung](https://github.com/ramsayleung) **Base:** `master` ← **Head:** `simplify-recommendations` --- ### 📝 Commits (4) - [`a3d14dc`](https://github.com/ramsayleung/rspotify/commit/a3d14dcdfaeb63c4afccb29c7b109197b7f30967) Simplify recommendations - [`0c767e7`](https://github.com/ramsayleung/rspotify/commit/0c767e7a1e54a58e0e0b8671013899ee5b147e18) Fix CI, generics for HashMap, ready 4 review - [`0b2c479`](https://github.com/ramsayleung/rspotify/commit/0b2c479c477512f238c3f739a98196c20b05e4d3) Serialize attributes - [`5d228ab`](https://github.com/ramsayleung/rspotify/commit/5d228ab71952ab0dce751917c12840c1c3290121) update changelog ### 📊 Changes **4 files changed** (+130 additions, -49 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELOG.md` (+1 -0) 📝 `rspotify-model/src/recommend.rs` (+105 -0) 📝 `src/clients/base.rs` (+15 -39) 📝 `tests/test_with_oauth.rs` (+9 -10) </details> ### 📄 Description ## Description The recommendations endpoint was very messy and had a long-standing TODO item. I've simplified it so that it just takes a map with the attributes that are directly appended to the query payload. ## Dependencies None ## Type of change Please delete options that are not relevant. - [x] Bug fix (non-breaking change which fixes an issue) ## How Has This Been Tested? The `test_recommendations` endpoint --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>