mirror of
https://github.com/ramsayleung/rspotify.git
synced 2026-04-26 07:55:55 +03:00
[PR #245] [MERGED] Fix cached token scopes #338
Labels
No labels
Stale
bug
discussion
enhancement
good first issue
good first issue
help wanted
pull-request
question
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/rspotify#338
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/ramsayleung/rspotify/pull/245
Author: @Rigellute
Created: 8/30/2021
Status: ✅ Merged
Merged: 8/30/2021
Merged by: @marioortizmanero
Base:
master← Head:master📝 Commits (1)
4a51f81Fix cached token scopes📊 Changes
1 file changed (+2 additions, -1 deletions)
View changed files
📝
src/lib.rs(+2 -1)📄 Description
Description
Serde rename "scopes" to "scope", but leave struct type as "scopes".
Motivation and Context
The cached auth token was not being restored from the cache, prompting the login flow every time.
On inspecting the cache, the "scopes" property was empty.
Turns out this was because the form response from spotify does not contain a "scopes" field. But instead contains a "scope".
This PR simply renames the property to "scopes" as it's a small change. Let me know if there's a more appropriate fix.
Dependencies
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
Please also list any relevant details for your test configuration
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.