[PR #241] [CLOSED] Fix IDs #334

New issue

Closed

opened 2026-02-27 20:24:17 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 20:24:17 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/ramsayleung/rspotify/pull/241
Author: @marioortizmanero
Created: 8/20/2021
Status: ❌ Closed

Base: master ← Head: fix-ids

📝 Commits (5)

c2046c7 Add UnknownId and some tests
d5d2812 Proper docs thanks to reworked macro
5a52393 Module-level documentation
1ab8ad1 Now with an example!
3b66b9a Stuck fighting compiler error about Deserialize

📊 Changes

17 files changed (+293 additions, -130 deletions)

View changed files

📝 rspotify-model/src/album.rs (+6 -10)
📝 rspotify-model/src/artist.rs (+4 -7)
📝 rspotify-model/src/audio.rs (+4 -3)
📝 rspotify-model/src/category.rs (+2 -2)
📝 rspotify-model/src/context.rs (+12 -11)
📝 rspotify-model/src/enums/types.rs (+1 -0)
📝 rspotify-model/src/idtypes.rs (+209 -29)
📝 rspotify-model/src/lib.rs (+2 -2)
📝 rspotify-model/src/playing.rs (+2 -3)
📝 rspotify-model/src/playlist.rs (+4 -8)
📝 rspotify-model/src/recommend.rs (+3 -3)
📝 rspotify-model/src/search.rs (+5 -6)
📝 rspotify-model/src/show.rs (+7 -11)
📝 rspotify-model/src/track.rs (+6 -19)
📝 rspotify-model/src/user.rs (+3 -6)
📝 src/clients/oauth.rs (+20 -6)
📝 tests/test_with_oauth.rs (+3 -4)

📄 Description

Description

This closes #203. It also includes a few more changes about IDs, like using them in rspotify-model, more tests and documenting them thoroughly.

Motivation and Context

I've fixed some of the issues I found about IDs. I still need to figure out :

how to take multiple types of IDs
how to fix some compiler issue about Deserialize<'_>

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/ramsayleung/rspotify/pull/241 **Author:** [@marioortizmanero](https://github.com/marioortizmanero) **Created:** 8/20/2021 **Status:** ❌ Closed **Base:** `master` ← **Head:** `fix-ids` --- ### 📝 Commits (5) - [`c2046c7`](https://github.com/ramsayleung/rspotify/commit/c2046c71a0408660ed6b49ea2a2914264865f388) Add UnknownId and some tests - [`d5d2812`](https://github.com/ramsayleung/rspotify/commit/d5d281249c73227870a4b487317ecbe89b4c9993) Proper docs thanks to reworked macro - [`5a52393`](https://github.com/ramsayleung/rspotify/commit/5a52393c384239a5b525505ccf75dd91e8f08806) Module-level documentation - [`1ab8ad1`](https://github.com/ramsayleung/rspotify/commit/1ab8ad1fcb82464a647728b8ed3b4d4b36b45f43) Now with an example! - [`3b66b9a`](https://github.com/ramsayleung/rspotify/commit/3b66b9a7c8a46c2cdb620ae68d7b88f15c3be6b2) Stuck fighting compiler error about Deserialize ### 📊 Changes **17 files changed** (+293 additions, -130 deletions) <details> <summary>View changed files</summary> 📝 `rspotify-model/src/album.rs` (+6 -10) 📝 `rspotify-model/src/artist.rs` (+4 -7) 📝 `rspotify-model/src/audio.rs` (+4 -3) 📝 `rspotify-model/src/category.rs` (+2 -2) 📝 `rspotify-model/src/context.rs` (+12 -11) 📝 `rspotify-model/src/enums/types.rs` (+1 -0) 📝 `rspotify-model/src/idtypes.rs` (+209 -29) 📝 `rspotify-model/src/lib.rs` (+2 -2) 📝 `rspotify-model/src/playing.rs` (+2 -3) 📝 `rspotify-model/src/playlist.rs` (+4 -8) 📝 `rspotify-model/src/recommend.rs` (+3 -3) 📝 `rspotify-model/src/search.rs` (+5 -6) 📝 `rspotify-model/src/show.rs` (+7 -11) 📝 `rspotify-model/src/track.rs` (+6 -19) 📝 `rspotify-model/src/user.rs` (+3 -6) 📝 `src/clients/oauth.rs` (+20 -6) 📝 `tests/test_with_oauth.rs` (+3 -4) </details> ### 📄 Description ## Description This closes #203. It also includes a few more changes about IDs, like using them in `rspotify-model`, more tests and documenting them thoroughly. ## Motivation and Context I've fixed *some* of the issues I found about IDs. I still need to figure out : * how to take multiple types of IDs * how to fix some compiler issue about `Deserialize<'_>` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>