[PR #239] [MERGED] Attempt 2 at simplifying the token reauth #330

New issue

Closed

opened 2026-02-27 20:24:17 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 20:24:17 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/ramsayleung/rspotify/pull/239
Author: @marioortizmanero
Created: 8/7/2021
Status: ✅ Merged
Merged: 8/8/2021
Merged by: @ramsayleung

Base: ramsay_support_refresh_token ← Head: refresh-token-simpler-2

📝 Commits (4)

7082eb0 Attempt 2 at simplifying code
7d2a122 Nicer initialization for tests
ce68bd7 Merge branch 'ramsay_support_refresh_token' into refresh-token-simpler-2
86eb6cd Fix tests

📊 Changes

11 files changed (+96 additions, -125 deletions)

View changed files

📝 examples/ureq/search.rs (+1 -1)
📝 examples/ureq/threading.rs (+1 -1)
📝 examples/with_auto_reauth.rs (+1 -11)
📝 examples/with_refresh_token.rs (+2 -11)
📝 src/auth_code.rs (+22 -40)
📝 src/auth_code_pkce.rs (+20 -38)
📝 src/client_creds.rs (+8 -0)
📝 src/clients/base.rs (+13 -0)
📝 src/clients/oauth.rs (+19 -8)
📝 tests/test_with_credential.rs (+1 -1)
📝 tests/test_with_oauth.rs (+8 -14)

📄 Description

This is a WIP attempt to simplify the code at #224

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/ramsayleung/rspotify/pull/239 **Author:** [@marioortizmanero](https://github.com/marioortizmanero) **Created:** 8/7/2021 **Status:** ✅ Merged **Merged:** 8/8/2021 **Merged by:** [@ramsayleung](https://github.com/ramsayleung) **Base:** `ramsay_support_refresh_token` ← **Head:** `refresh-token-simpler-2` --- ### 📝 Commits (4) - [`7082eb0`](https://github.com/ramsayleung/rspotify/commit/7082eb0f40991c643482ac55ee575c46c9d0d9f4) Attempt 2 at simplifying code - [`7d2a122`](https://github.com/ramsayleung/rspotify/commit/7d2a12259f0731460a3f2ec90741b33552eaabbd) Nicer initialization for tests - [`ce68bd7`](https://github.com/ramsayleung/rspotify/commit/ce68bd76625ebbf43d72e224dba3dd9d4064198d) Merge branch 'ramsay_support_refresh_token' into refresh-token-simpler-2 - [`86eb6cd`](https://github.com/ramsayleung/rspotify/commit/86eb6cd0739ad972daefd3efc443e301db8fbdac) Fix tests ### 📊 Changes **11 files changed** (+96 additions, -125 deletions) <details> <summary>View changed files</summary> 📝 `examples/ureq/search.rs` (+1 -1) 📝 `examples/ureq/threading.rs` (+1 -1) 📝 `examples/with_auto_reauth.rs` (+1 -11) 📝 `examples/with_refresh_token.rs` (+2 -11) 📝 `src/auth_code.rs` (+22 -40) 📝 `src/auth_code_pkce.rs` (+20 -38) 📝 `src/client_creds.rs` (+8 -0) 📝 `src/clients/base.rs` (+13 -0) 📝 `src/clients/oauth.rs` (+19 -8) 📝 `tests/test_with_credential.rs` (+1 -1) 📝 `tests/test_with_oauth.rs` (+8 -14) </details> ### 📄 Description This is a WIP attempt to simplify the code at #224 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>