[PR #215] [MERGED] [Auth restructure 3] Split up `Spotify` into multiple clients #319

New issue

Closed

opened 2026-02-27 20:24:14 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 20:24:14 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/ramsayleung/rspotify/pull/215
Author: @marioortizmanero
Created: 6/19/2021
Status: ✅ Merged
Merged: 7/8/2021
Merged by: @ramsayleung

Base: auth-rewrite-part2 ← Head: auth-rewrite-part3

📝 Commits (10+)

506ff25 split up the source into multiple files and clients
90d673f update tests
9b2cbbb update examples
f8ab718 update CI
b34be92 fix Cargo.toml
0e10b0f Merge branch 'auth-rewrite-part2' into auth-rewrite-part3
6ebf37e Merge branch 'auth-rewrite-part3' into auth-rewrite-part4
4ab9300 Merge branch 'auth-rewrite-part2' into auth-rewrite-part3
debb42c Merge branch 'auth-rewrite-part3' into auth-rewrite-part4
210cd1d Added an upgrade guide

📊 Changes

45 files changed (+3916 additions, -3814 deletions)

View changed files

📝 .github/workflows/ci.yml (+22 -54)
➖ .travis.yml (+0 -25)
📝 CHANGELOG.md (+97 -24)
📝 Cargo.toml (+2 -2)
➕ examples/auth_code.rs (+55 -0)
➕ examples/auth_code_pkce.rs (+47 -0)
📝 examples/client_creds.rs (+10 -14)
➖ examples/current_user_recently_played.rs (+0 -51)
📝 examples/oauth_tokens.rs (+7 -12)
📝 examples/pagination_async.rs (+6 -36)
📝 examples/pagination_manual.rs (+6 -36)
📝 examples/pagination_sync.rs (+6 -36)
➖ examples/track.rs (+0 -42)
➖ examples/tracks.rs (+0 -42)
📝 examples/ureq/device.rs (+6 -36)
📝 examples/ureq/me.rs (+6 -36)
📝 examples/ureq/search.rs (+17 -47)
📝 examples/ureq/seek_track.rs (+6 -36)
📝 examples/webapp/src/main.rs (+71 -78)
📝 examples/with_refresh_token.rs (+12 -27)

...and 25 more files

📄 Description

Part 3 of splitting up #207, possibly the biggest of all changes. There's no way to reduce the number of changes here, really, as it requires moving most of the client's code into multiple files and different structures. But it doesn't really introduce that many changes. The endpoints themselves aren't changed at all and can be ignored, as they just were moved into traits.

The main library should be able to compile without problems after this PR.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/ramsayleung/rspotify/pull/215 **Author:** [@marioortizmanero](https://github.com/marioortizmanero) **Created:** 6/19/2021 **Status:** ✅ Merged **Merged:** 7/8/2021 **Merged by:** [@ramsayleung](https://github.com/ramsayleung) **Base:** `auth-rewrite-part2` ← **Head:** `auth-rewrite-part3` --- ### 📝 Commits (10+) - [`506ff25`](https://github.com/ramsayleung/rspotify/commit/506ff25259791e73c3d78f1d31be8a5547d42cae) split up the source into multiple files and clients - [`90d673f`](https://github.com/ramsayleung/rspotify/commit/90d673f14d37f88cb22125ffda51fdd5128bec2a) update tests - [`9b2cbbb`](https://github.com/ramsayleung/rspotify/commit/9b2cbbbb6e080afd831d113e064cc0dfa78bd88d) update examples - [`f8ab718`](https://github.com/ramsayleung/rspotify/commit/f8ab71850c8722d64cc0d9b5c9b6b8214d57a42e) update CI - [`b34be92`](https://github.com/ramsayleung/rspotify/commit/b34be92be1825330664470008e17f5e322a4eb92) fix Cargo.toml - [`0e10b0f`](https://github.com/ramsayleung/rspotify/commit/0e10b0f70e7fcf4f26b95a281adc919fc7686090) Merge branch 'auth-rewrite-part2' into auth-rewrite-part3 - [`6ebf37e`](https://github.com/ramsayleung/rspotify/commit/6ebf37e16bee10eb6f2257b060dbfd5f02edd38d) Merge branch 'auth-rewrite-part3' into auth-rewrite-part4 - [`4ab9300`](https://github.com/ramsayleung/rspotify/commit/4ab9300e4649db2e9edf04fd2f48977348e69457) Merge branch 'auth-rewrite-part2' into auth-rewrite-part3 - [`debb42c`](https://github.com/ramsayleung/rspotify/commit/debb42cf567ea706e8da9572c0869173a7717fad) Merge branch 'auth-rewrite-part3' into auth-rewrite-part4 - [`210cd1d`](https://github.com/ramsayleung/rspotify/commit/210cd1d459ed2f07ffef7a265728a42e2a452cd3) Added an upgrade guide ### 📊 Changes **45 files changed** (+3916 additions, -3814 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/ci.yml` (+22 -54) ➖ `.travis.yml` (+0 -25) 📝 `CHANGELOG.md` (+97 -24) 📝 `Cargo.toml` (+2 -2) ➕ `examples/auth_code.rs` (+55 -0) ➕ `examples/auth_code_pkce.rs` (+47 -0) 📝 `examples/client_creds.rs` (+10 -14) ➖ `examples/current_user_recently_played.rs` (+0 -51) 📝 `examples/oauth_tokens.rs` (+7 -12) 📝 `examples/pagination_async.rs` (+6 -36) 📝 `examples/pagination_manual.rs` (+6 -36) 📝 `examples/pagination_sync.rs` (+6 -36) ➖ `examples/track.rs` (+0 -42) ➖ `examples/tracks.rs` (+0 -42) 📝 `examples/ureq/device.rs` (+6 -36) 📝 `examples/ureq/me.rs` (+6 -36) 📝 `examples/ureq/search.rs` (+17 -47) 📝 `examples/ureq/seek_track.rs` (+6 -36) 📝 `examples/webapp/src/main.rs` (+71 -78) 📝 `examples/with_refresh_token.rs` (+12 -27) _...and 25 more files_ </details> ### 📄 Description Part 3 of splitting up #207, possibly the biggest of all changes. There's no way to reduce the number of changes here, really, as it requires moving most of the client's code into multiple files and different structures. But it doesn't really introduce that many changes. The endpoints themselves aren't changed at all and can be ignored, as they just were moved into traits. The main library should be able to compile without problems after this PR. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>