[PR #214] [MERGED] [Auth restructure 2] Some fixes for `rspotify-model` and `rspotify-macros` #318

New issue

Closed

opened 2026-02-27 20:24:14 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 20:24:14 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/ramsayleung/rspotify/pull/214
Author: @marioortizmanero
Created: 6/19/2021
Status: ✅ Merged
Merged: 7/8/2021
Merged by: @ramsayleung

Base: auth-rewrite-part1 ← Head: auth-rewrite-part2

📝 Commits (10+)

6235c67 small fixes for rspotify-model
8397c9b small fixes for rspotify-macros
506ff25 split up the source into multiple files and clients
90d673f update tests
9b2cbbb update examples
f8ab718 update CI
b34be92 fix Cargo.toml
0e10b0f Merge branch 'auth-rewrite-part2' into auth-rewrite-part3
6ebf37e Merge branch 'auth-rewrite-part3' into auth-rewrite-part4
6f8162e Merge branch 'auth-rewrite-part1' into auth-rewrite-part2

📊 Changes

48 files changed (+3951 additions, -3853 deletions)

View changed files

📝 .github/workflows/ci.yml (+22 -54)
➖ .travis.yml (+0 -25)
📝 CHANGELOG.md (+97 -24)
📝 Cargo.toml (+2 -2)
➕ examples/auth_code.rs (+55 -0)
➕ examples/auth_code_pkce.rs (+47 -0)
📝 examples/client_creds.rs (+10 -14)
➖ examples/current_user_recently_played.rs (+0 -51)
📝 examples/oauth_tokens.rs (+7 -12)
📝 examples/pagination_async.rs (+6 -36)
📝 examples/pagination_manual.rs (+6 -36)
📝 examples/pagination_sync.rs (+6 -36)
➖ examples/track.rs (+0 -42)
➖ examples/tracks.rs (+0 -42)
📝 examples/ureq/device.rs (+6 -36)
📝 examples/ureq/me.rs (+6 -36)
📝 examples/ureq/search.rs (+17 -47)
📝 examples/ureq/seek_track.rs (+6 -36)
📝 examples/webapp/src/main.rs (+71 -78)
📝 examples/with_refresh_token.rs (+12 -27)

...and 28 more files

📄 Description

Part 2 of the #207 split-up.

This:

Fixes some small things in rspotify-model
Fixes some small things in rspotify-macros

These things are needed later to test the crate without cyclical dependencies, and mostly clean up a few things. Both of the crates I modified should compile without problems, but not the main one.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/ramsayleung/rspotify/pull/214 **Author:** [@marioortizmanero](https://github.com/marioortizmanero) **Created:** 6/19/2021 **Status:** ✅ Merged **Merged:** 7/8/2021 **Merged by:** [@ramsayleung](https://github.com/ramsayleung) **Base:** `auth-rewrite-part1` ← **Head:** `auth-rewrite-part2` --- ### 📝 Commits (10+) - [`6235c67`](https://github.com/ramsayleung/rspotify/commit/6235c67ec68c2e5f2112825c469c15baffebfbc0) small fixes for rspotify-model - [`8397c9b`](https://github.com/ramsayleung/rspotify/commit/8397c9b976f75b55fce159afb9381a526e41da9a) small fixes for rspotify-macros - [`506ff25`](https://github.com/ramsayleung/rspotify/commit/506ff25259791e73c3d78f1d31be8a5547d42cae) split up the source into multiple files and clients - [`90d673f`](https://github.com/ramsayleung/rspotify/commit/90d673f14d37f88cb22125ffda51fdd5128bec2a) update tests - [`9b2cbbb`](https://github.com/ramsayleung/rspotify/commit/9b2cbbbb6e080afd831d113e064cc0dfa78bd88d) update examples - [`f8ab718`](https://github.com/ramsayleung/rspotify/commit/f8ab71850c8722d64cc0d9b5c9b6b8214d57a42e) update CI - [`b34be92`](https://github.com/ramsayleung/rspotify/commit/b34be92be1825330664470008e17f5e322a4eb92) fix Cargo.toml - [`0e10b0f`](https://github.com/ramsayleung/rspotify/commit/0e10b0f70e7fcf4f26b95a281adc919fc7686090) Merge branch 'auth-rewrite-part2' into auth-rewrite-part3 - [`6ebf37e`](https://github.com/ramsayleung/rspotify/commit/6ebf37e16bee10eb6f2257b060dbfd5f02edd38d) Merge branch 'auth-rewrite-part3' into auth-rewrite-part4 - [`6f8162e`](https://github.com/ramsayleung/rspotify/commit/6f8162e8fdcbbfe60c17db70eacc6714d38f5ab6) Merge branch 'auth-rewrite-part1' into auth-rewrite-part2 ### 📊 Changes **48 files changed** (+3951 additions, -3853 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/ci.yml` (+22 -54) ➖ `.travis.yml` (+0 -25) 📝 `CHANGELOG.md` (+97 -24) 📝 `Cargo.toml` (+2 -2) ➕ `examples/auth_code.rs` (+55 -0) ➕ `examples/auth_code_pkce.rs` (+47 -0) 📝 `examples/client_creds.rs` (+10 -14) ➖ `examples/current_user_recently_played.rs` (+0 -51) 📝 `examples/oauth_tokens.rs` (+7 -12) 📝 `examples/pagination_async.rs` (+6 -36) 📝 `examples/pagination_manual.rs` (+6 -36) 📝 `examples/pagination_sync.rs` (+6 -36) ➖ `examples/track.rs` (+0 -42) ➖ `examples/tracks.rs` (+0 -42) 📝 `examples/ureq/device.rs` (+6 -36) 📝 `examples/ureq/me.rs` (+6 -36) 📝 `examples/ureq/search.rs` (+17 -47) 📝 `examples/ureq/seek_track.rs` (+6 -36) 📝 `examples/webapp/src/main.rs` (+71 -78) 📝 `examples/with_refresh_token.rs` (+12 -27) _...and 28 more files_ </details> ### 📄 Description Part 2 of the #207 split-up. This: * Fixes some small things in `rspotify-model` * Fixes some small things in `rspotify-macros` These things are needed later to test the crate without cyclical dependencies, and mostly clean up a few things. Both of the crates I modified should compile without problems, but not the main one. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>