[PR #213] [MERGED] [Auth restructure 1] Separate http into a new crate #317

New issue

Closed

opened 2026-02-27 20:24:14 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 20:24:14 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/ramsayleung/rspotify/pull/213
Author: @marioortizmanero
Created: 6/19/2021
Status: ✅ Merged
Merged: 7/8/2021
Merged by: @ramsayleung

Base: separate-crates ← Head: auth-rewrite-part1

📝 Commits (10+)

2c3446d new crate
188a863 mod.rs -> lib.rs
36489b4 add common.rs
6ad7fd6 update to last version
e3594d8 update cargo.toml
ac9380e now compiling
6235c67 small fixes for rspotify-model
8397c9b small fixes for rspotify-macros
506ff25 split up the source into multiple files and clients
90d673f update tests

📊 Changes

52 files changed (+4141 additions, -4218 deletions)

View changed files

📝 .github/workflows/ci.yml (+22 -54)
➖ .travis.yml (+0 -25)
📝 CHANGELOG.md (+97 -24)
📝 Cargo.toml (+29 -38)
➕ examples/auth_code.rs (+55 -0)
➕ examples/auth_code_pkce.rs (+47 -0)
📝 examples/client_creds.rs (+10 -14)
➖ examples/current_user_recently_played.rs (+0 -51)
📝 examples/oauth_tokens.rs (+7 -12)
📝 examples/pagination_async.rs (+6 -36)
📝 examples/pagination_manual.rs (+6 -36)
📝 examples/pagination_sync.rs (+6 -36)
➖ examples/track.rs (+0 -42)
➖ examples/tracks.rs (+0 -42)
📝 examples/ureq/device.rs (+6 -36)
📝 examples/ureq/me.rs (+6 -36)
📝 examples/ureq/search.rs (+17 -47)
📝 examples/ureq/seek_track.rs (+6 -36)
📝 examples/webapp/src/main.rs (+71 -78)
📝 examples/with_refresh_token.rs (+12 -27)

...and 32 more files

📄 Description

Part 1 of splitting up #207.

This moves the http logic into its own crate. It should be able to compile by itself (but not rspotify itself)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/ramsayleung/rspotify/pull/213 **Author:** [@marioortizmanero](https://github.com/marioortizmanero) **Created:** 6/19/2021 **Status:** ✅ Merged **Merged:** 7/8/2021 **Merged by:** [@ramsayleung](https://github.com/ramsayleung) **Base:** `separate-crates` ← **Head:** `auth-rewrite-part1` --- ### 📝 Commits (10+) - [`2c3446d`](https://github.com/ramsayleung/rspotify/commit/2c3446d4ef9601f97ada10310dbec204ec763155) new crate - [`188a863`](https://github.com/ramsayleung/rspotify/commit/188a863dee610bd52f543467705dd3993c6de069) mod.rs -> lib.rs - [`36489b4`](https://github.com/ramsayleung/rspotify/commit/36489b4895089c76c49846c1372141ec0aa63163) add common.rs - [`6ad7fd6`](https://github.com/ramsayleung/rspotify/commit/6ad7fd61b47e95cbf2ddfa14b326536db990628d) update to last version - [`e3594d8`](https://github.com/ramsayleung/rspotify/commit/e3594d863067215f7f83e16cf5ed4ea76c5dc439) update cargo.toml - [`ac9380e`](https://github.com/ramsayleung/rspotify/commit/ac9380e7c22a9dc1af478fb5ea20592a49d4b00a) now compiling - [`6235c67`](https://github.com/ramsayleung/rspotify/commit/6235c67ec68c2e5f2112825c469c15baffebfbc0) small fixes for rspotify-model - [`8397c9b`](https://github.com/ramsayleung/rspotify/commit/8397c9b976f75b55fce159afb9381a526e41da9a) small fixes for rspotify-macros - [`506ff25`](https://github.com/ramsayleung/rspotify/commit/506ff25259791e73c3d78f1d31be8a5547d42cae) split up the source into multiple files and clients - [`90d673f`](https://github.com/ramsayleung/rspotify/commit/90d673f14d37f88cb22125ffda51fdd5128bec2a) update tests ### 📊 Changes **52 files changed** (+4141 additions, -4218 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/ci.yml` (+22 -54) ➖ `.travis.yml` (+0 -25) 📝 `CHANGELOG.md` (+97 -24) 📝 `Cargo.toml` (+29 -38) ➕ `examples/auth_code.rs` (+55 -0) ➕ `examples/auth_code_pkce.rs` (+47 -0) 📝 `examples/client_creds.rs` (+10 -14) ➖ `examples/current_user_recently_played.rs` (+0 -51) 📝 `examples/oauth_tokens.rs` (+7 -12) 📝 `examples/pagination_async.rs` (+6 -36) 📝 `examples/pagination_manual.rs` (+6 -36) 📝 `examples/pagination_sync.rs` (+6 -36) ➖ `examples/track.rs` (+0 -42) ➖ `examples/tracks.rs` (+0 -42) 📝 `examples/ureq/device.rs` (+6 -36) 📝 `examples/ureq/me.rs` (+6 -36) 📝 `examples/ureq/search.rs` (+17 -47) 📝 `examples/ureq/seek_track.rs` (+6 -36) 📝 `examples/webapp/src/main.rs` (+71 -78) 📝 `examples/with_refresh_token.rs` (+12 -27) _...and 32 more files_ </details> ### 📄 Description Part 1 of splitting up #207. This moves the http logic into its own crate. It should be able to compile by itself (but not `rspotify` itself) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>