[PR #199] [MERGED] Separate crates #309

New issue

Closed

opened 2026-02-27 20:24:12 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 20:24:12 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/ramsayleung/rspotify/pull/199
Author: @marioortizmanero
Created: 4/13/2021
Status: ✅ Merged
Merged: 7/8/2021
Merged by: @ramsayleung

Base: master ← Head: separate-crates

📝 Commits (10+)

dcdc16d directory re-organization
0a672cb rspotify model working
f3a3636 some fixes for model and http
ff477b5 merge client, auth and http again
9b921c4 cargo build works now
7991aad new attempt
9ba82f7 underscore to hyphen
943230f crates now compiling
5f5d31b last compilation fixes
b9b346d format, revert some changes

📊 Changes

69 files changed (+4208 additions, -4223 deletions)

View changed files

📝 .github/workflows/ci.yml (+32 -65)
➖ .travis.yml (+0 -25)
📝 CHANGELOG.md (+98 -24)
📝 Cargo.toml (+53 -33)
➕ examples/auth_code.rs (+55 -0)
➕ examples/auth_code_pkce.rs (+47 -0)
📝 examples/client_creds.rs (+10 -14)
➖ examples/current_user_recently_played.rs (+0 -51)
📝 examples/oauth_tokens.rs (+7 -12)
📝 examples/pagination_async.rs (+6 -36)
📝 examples/pagination_manual.rs (+6 -36)
📝 examples/pagination_sync.rs (+6 -36)
➖ examples/track.rs (+0 -42)
➖ examples/tracks.rs (+0 -42)
📝 examples/ureq/device.rs (+6 -36)
📝 examples/ureq/me.rs (+6 -36)
📝 examples/ureq/search.rs (+17 -47)
📝 examples/ureq/seek_track.rs (+6 -38)
📝 examples/webapp/src/main.rs (+71 -78)
📝 examples/with_refresh_token.rs (+12 -27)

...and 49 more files

📄 Description

Description

Some work towards #191. I've ended up separating the crates but leaving the auth, http and client ones mixed under rspotify_client until #173 is worked on.

Motivation and Context

See #191

Dependencies

Should be the same

Type of change

Please delete options that are not relevant.

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update

This change means that types like FullAlbum in the model now have to be public.

How Has This Been Tested?

The previous tests still work now. Same goes for the examples (which by the way I had to fix because they weren't working)

Closes #191

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/ramsayleung/rspotify/pull/199 **Author:** [@marioortizmanero](https://github.com/marioortizmanero) **Created:** 4/13/2021 **Status:** ✅ Merged **Merged:** 7/8/2021 **Merged by:** [@ramsayleung](https://github.com/ramsayleung) **Base:** `master` ← **Head:** `separate-crates` --- ### 📝 Commits (10+) - [`dcdc16d`](https://github.com/ramsayleung/rspotify/commit/dcdc16df8cefb8ddf4e5a50084fb2a63e784e58c) directory re-organization - [`0a672cb`](https://github.com/ramsayleung/rspotify/commit/0a672cb454076496ba34639a166aa68f5e7590d2) rspotify model working - [`f3a3636`](https://github.com/ramsayleung/rspotify/commit/f3a363656cca89607a995cd9469de89fef279be0) some fixes for model and http - [`ff477b5`](https://github.com/ramsayleung/rspotify/commit/ff477b5acddb10cd3ea58f18c7badeda85f4a32f) merge client, auth and http again - [`9b921c4`](https://github.com/ramsayleung/rspotify/commit/9b921c48c558542314d4aa6192bec902615930e4) cargo build works now - [`7991aad`](https://github.com/ramsayleung/rspotify/commit/7991aad6ba9e304353fb12f538a58f82a546d126) new attempt - [`9ba82f7`](https://github.com/ramsayleung/rspotify/commit/9ba82f7f2348a8bf081454bb2228680178aac331) underscore to hyphen - [`943230f`](https://github.com/ramsayleung/rspotify/commit/943230f3c8c81b2c94a9a2e86f3746f75e58c8d3) crates now compiling - [`5f5d31b`](https://github.com/ramsayleung/rspotify/commit/5f5d31bb2bc991b97304bbe7f95c51ef9a0903c2) last compilation fixes - [`b9b346d`](https://github.com/ramsayleung/rspotify/commit/b9b346dace6d7c6df4810ad1510ae828750864b1) format, revert some changes ### 📊 Changes **69 files changed** (+4208 additions, -4223 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/ci.yml` (+32 -65) ➖ `.travis.yml` (+0 -25) 📝 `CHANGELOG.md` (+98 -24) 📝 `Cargo.toml` (+53 -33) ➕ `examples/auth_code.rs` (+55 -0) ➕ `examples/auth_code_pkce.rs` (+47 -0) 📝 `examples/client_creds.rs` (+10 -14) ➖ `examples/current_user_recently_played.rs` (+0 -51) 📝 `examples/oauth_tokens.rs` (+7 -12) 📝 `examples/pagination_async.rs` (+6 -36) 📝 `examples/pagination_manual.rs` (+6 -36) 📝 `examples/pagination_sync.rs` (+6 -36) ➖ `examples/track.rs` (+0 -42) ➖ `examples/tracks.rs` (+0 -42) 📝 `examples/ureq/device.rs` (+6 -36) 📝 `examples/ureq/me.rs` (+6 -36) 📝 `examples/ureq/search.rs` (+17 -47) 📝 `examples/ureq/seek_track.rs` (+6 -38) 📝 `examples/webapp/src/main.rs` (+71 -78) 📝 `examples/with_refresh_token.rs` (+12 -27) _...and 49 more files_ </details> ### 📄 Description ## Description Some work towards #191. I've ended up separating the crates but leaving the auth, http and client ones mixed under `rspotify_client` until #173 is worked on. ## Motivation and Context See #191 ## Dependencies Should be the same ## Type of change Please delete options that are not relevant. - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [x] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] This change requires a documentation update This change means that types like `FullAlbum` in the model now have to be public. ## How Has This Been Tested? The previous tests still work now. Same goes for the examples (which by the way I had to fix because they weren't working) --- Closes #191 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>