[PR #198] [CLOSED] Added missing parameter from current_user_recently_played() #307

New issue

Closed

opened 2026-02-27 20:24:11 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 20:24:11 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/ramsayleung/rspotify/pull/198
Author: @hellbound22
Created: 4/9/2021
Status: ❌ Closed

Base: master ← Head: recently_played_after

📝 Commits (9)

379655a Added missing parameters in current_user_recently_played()
5c3364e Changed primitive type
9b6b7ab Update Cargo.toml
cabcf8b Update the docs
a341212 Merge branch 'recently_played_after' of https://github.com/hellbound22/rspotify into recently_played_after
44b953e Merge branch 'master' of https://github.com/ramsayleung/rspotify into HEAD
5a9ed4e Updated examples
55ceca8 Fixed lints
24fb714 Fixed clippy error

📊 Changes

5 files changed (+26 additions, -4 deletions)

View changed files

📝 examples/current_user_recently_played.rs (+1 -1)
📝 src/client.rs (+15 -2)
➕ src/model/enums/.misc.rs.swp (+0 -0)
📝 src/model/enums/misc.rs (+9 -0)
📝 tests/test_with_oauth.rs (+1 -1)

📄 Description

Description

Fix the implementation of current_user_recently_played() with the missing parameters.

Motivation and Context

The Spotify web api of current_user_recently_played() has the parameters before and after that are not implemented in this crate.

Dependencies

None

Type of change

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update

How Has This Been Tested?

The OAuth2 test passes when adding the None as the second parameter. Might have to write another test when the Option is Some(_)

Also, been using this with success in a project of mine.

Please also list any relevant details for your test configuration

test_with_oauth::test_current_user_recently_played()

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/ramsayleung/rspotify/pull/198 **Author:** [@hellbound22](https://github.com/hellbound22) **Created:** 4/9/2021 **Status:** ❌ Closed **Base:** `master` ← **Head:** `recently_played_after` --- ### 📝 Commits (9) - [`379655a`](https://github.com/ramsayleung/rspotify/commit/379655a0aba63eaa44a54d5775d0684f79e64e91) Added missing parameters in current_user_recently_played() - [`5c3364e`](https://github.com/ramsayleung/rspotify/commit/5c3364e89a591306a506a560ba68909e96df516c) Changed primitive type - [`9b6b7ab`](https://github.com/ramsayleung/rspotify/commit/9b6b7abd0617c9111ff56ea4fc3bbb90155da405) Update Cargo.toml - [`cabcf8b`](https://github.com/ramsayleung/rspotify/commit/cabcf8b6add985c7004059e885eacbfb00ba8819) Update the docs - [`a341212`](https://github.com/ramsayleung/rspotify/commit/a341212db3b6c308bd208c724f8a55d9255f68f7) Merge branch 'recently_played_after' of https://github.com/hellbound22/rspotify into recently_played_after - [`44b953e`](https://github.com/ramsayleung/rspotify/commit/44b953e892da416946f58ec336c67f390f8dbcb0) Merge branch 'master' of https://github.com/ramsayleung/rspotify into HEAD - [`5a9ed4e`](https://github.com/ramsayleung/rspotify/commit/5a9ed4ea09d45512751e2f7f5112e20ac80388c7) Updated examples - [`55ceca8`](https://github.com/ramsayleung/rspotify/commit/55ceca8c883a2869a009fd69b909c312e6cc0e40) Fixed lints - [`24fb714`](https://github.com/ramsayleung/rspotify/commit/24fb71443be3fba69473a6c77c135428a916194f) Fixed clippy error ### 📊 Changes **5 files changed** (+26 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `examples/current_user_recently_played.rs` (+1 -1) 📝 `src/client.rs` (+15 -2) ➕ `src/model/enums/.misc.rs.swp` (+0 -0) 📝 `src/model/enums/misc.rs` (+9 -0) 📝 `tests/test_with_oauth.rs` (+1 -1) </details> ### 📄 Description ## Description Fix the implementation of ```current_user_recently_played()``` with the missing parameters. ## Motivation and Context The Spotify web api of ```current_user_recently_played()``` has the parameters ```before``` and ```after``` that are not implemented in this crate. ## Dependencies None ## Type of change - [x] Bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds functionality) - [x] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [x] This change requires a documentation update ## How Has This Been Tested? The OAuth2 test passes when adding the ```None``` as the second parameter. Might have to write another test when the Option is ```Some(_)``` Also, been using this with success in a project of mine. Please also list any relevant details for your test configuration - [x] ```test_with_oauth::test_current_user_recently_played()``` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>