[PR #191] [CLOSED] Move model into a separate rspotify-model crate #300

New issue

Closed

opened 2026-02-27 20:24:10 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 20:24:10 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/ramsayleung/rspotify/pull/191
Author: @udoprog
Created: 3/7/2021
Status: ❌ Closed

Base: master ← Head: model

📝 Commits (1)

0c52482 Move model into rspotify-model

📊 Changes

25 files changed (+44 additions, -25 deletions)

View changed files

📝 Cargo.toml (+2 -1)
➕ model/Cargo.toml (+17 -0)
📝 model/src/album.rs (+3 -3)
📝 model/src/artist.rs (+3 -3)
📝 model/src/audio.rs (+2 -2)
📝 model/src/category.rs (+1 -1)
📝 model/src/context.rs (+1 -1)
📝 model/src/device.rs (+2 -2)
📝 model/src/enums/country.rs (+0 -0)
📝 model/src/enums/misc.rs (+0 -0)
📝 model/src/enums/mod.rs (+0 -0)
📝 model/src/enums/types.rs (+0 -0)
📝 model/src/idtypes.rs (+1 -1)
📝 model/src/image.rs (+0 -0)
📝 model/src/lib.rs (+1 -1)
📝 model/src/offset.rs (+1 -1)
📝 model/src/page.rs (+0 -0)
📝 model/src/playing.rs (+0 -0)
📝 model/src/playlist.rs (+2 -2)
📝 model/src/recommend.rs (+1 -1)

...and 5 more files

📄 Description

Description

This extracts the models used into a separate crate, so they can be used separately from the client implementation.

Motivation and Context

I have a separate client which is not suitable for general use that does not need the client bits, but could benefit greatly from the models.

Type of change

Please delete options that are not relevant.

New feature (non-breaking change which adds functionality)

This also requires that the next release of rspotify releases the rspotify-model crate. The separated crate is being re-exported with the same API as before. A few models have been modified from being pub(in crate) to just be pub.

How Has This Been Tested?

Just built for now. I don't have the necessary plumbing to run the integration tests, so we'll see if they pass through Github Actions.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/ramsayleung/rspotify/pull/191 **Author:** [@udoprog](https://github.com/udoprog) **Created:** 3/7/2021 **Status:** ❌ Closed **Base:** `master` ← **Head:** `model` --- ### 📝 Commits (1) - [`0c52482`](https://github.com/ramsayleung/rspotify/commit/0c524827b7684e365ee61317bc6a1a6fafc5640d) Move model into rspotify-model ### 📊 Changes **25 files changed** (+44 additions, -25 deletions) <details> <summary>View changed files</summary> 📝 `Cargo.toml` (+2 -1) ➕ `model/Cargo.toml` (+17 -0) 📝 `model/src/album.rs` (+3 -3) 📝 `model/src/artist.rs` (+3 -3) 📝 `model/src/audio.rs` (+2 -2) 📝 `model/src/category.rs` (+1 -1) 📝 `model/src/context.rs` (+1 -1) 📝 `model/src/device.rs` (+2 -2) 📝 `model/src/enums/country.rs` (+0 -0) 📝 `model/src/enums/misc.rs` (+0 -0) 📝 `model/src/enums/mod.rs` (+0 -0) 📝 `model/src/enums/types.rs` (+0 -0) 📝 `model/src/idtypes.rs` (+1 -1) 📝 `model/src/image.rs` (+0 -0) 📝 `model/src/lib.rs` (+1 -1) 📝 `model/src/offset.rs` (+1 -1) 📝 `model/src/page.rs` (+0 -0) 📝 `model/src/playing.rs` (+0 -0) 📝 `model/src/playlist.rs` (+2 -2) 📝 `model/src/recommend.rs` (+1 -1) _...and 5 more files_ </details> ### 📄 Description ## Description This extracts the models used into a separate crate, so they can be used separately from the client implementation. ## Motivation and Context I have a separate client which is not suitable for general use that does not need the client bits, but could benefit greatly from the models. ## Type of change Please delete options that are not relevant. - [x] New feature (non-breaking change which adds functionality) This also requires that the next release of `rspotify` releases the `rspotify-model` crate. The separated crate is being re-exported with the same API as before. A few models have been modified from being `pub(in crate)` to just be `pub`. ## How Has This Been Tested? Just built for now. I don't have the necessary plumbing to run the integration tests, so we'll see if they pass through Github Actions. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>