[PR #171] [MERGED] Improved test error messages and small CI fix #287

New issue

Closed

opened 2026-02-27 20:24:06 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 20:24:06 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/ramsayleung/rspotify/pull/171
Author: @marioortizmanero
Created: 12/25/2020
Status: ✅ Merged
Merged: 1/19/2021
Merged by: @ramsayleung

Base: master ← Head: tests-features

📝 Commits (3)

86dc798 improve error messages from tests
a266def remove unnecessary feature in CI tests
e94ce7a same messages

📊 Changes

3 files changed (+17 additions, -5 deletions)

View changed files

📝 .github/workflows/ci.yml (+1 -1)
📝 tests/test_with_credential.rs (+8 -3)
📝 tests/test_with_oauth.rs (+8 -1)

📄 Description

Description

If you ran cargo test without the env-file feature by mistake or no credentials set, you'd get a somewhat weird error. This should provide more context for both test_with_credential and test_with_oauth. I also removed the cli feature from the CI tests as it's not really needed for now (CI can't interact with the user anyway).

Type of change

Please delete options that are not relevant.

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update

How Has This Been Tested?

I've just ran the tests a couple times expecting these errors

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/ramsayleung/rspotify/pull/171 **Author:** [@marioortizmanero](https://github.com/marioortizmanero) **Created:** 12/25/2020 **Status:** ✅ Merged **Merged:** 1/19/2021 **Merged by:** [@ramsayleung](https://github.com/ramsayleung) **Base:** `master` ← **Head:** `tests-features` --- ### 📝 Commits (3) - [`86dc798`](https://github.com/ramsayleung/rspotify/commit/86dc7987b597b417349ffa3f3b485d52adbd3a19) improve error messages from tests - [`a266def`](https://github.com/ramsayleung/rspotify/commit/a266def430a792db2595db0036ac40afcc4898bd) remove unnecessary feature in CI tests - [`e94ce7a`](https://github.com/ramsayleung/rspotify/commit/e94ce7ab3a66b9ed8ad67989e34db1298447fb0b) same messages ### 📊 Changes **3 files changed** (+17 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/ci.yml` (+1 -1) 📝 `tests/test_with_credential.rs` (+8 -3) 📝 `tests/test_with_oauth.rs` (+8 -1) </details> ### 📄 Description ## Description If you ran `cargo test` without the `env-file` feature by mistake or no credentials set, you'd get a somewhat weird error. This should provide more context for both `test_with_credential` and `test_with_oauth`. I also removed the `cli` feature from the CI tests as it's not really needed for now (CI can't interact with the user anyway). ## Type of change Please delete options that are not relevant. - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] This change requires a documentation update ## How Has This Been Tested? I've just ran the tests a couple times expecting these errors --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>