[PR #151] [CLOSED] Adding Authorization Code Flow with Proof Key for Code Exchange (PKCE) #271

New issue

Closed

opened 2026-02-27 20:24:03 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 20:24:03 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/ramsayleung/rspotify/pull/151
Author: @martinmake
Created: 11/8/2020
Status: ❌ Closed

Base: master ← Head: master

📝 Commits (1)

904bab0 Initial draft

📊 Changes

3 files changed (+78 additions, -2 deletions)

View changed files

📝 Cargo.toml (+6 -1)
➕ examples/pkce_oauth_tokens.rs (+59 -0)
📝 src/oauth2.rs (+13 -1)

📄 Description

I would start with a discussion about the user interface.
I've added an example for this feature so we can have the same context.

What do you think about it?

Should we use:

pub enum AuthorizationFlow to choose between Authorization Flows, or
builders/functions, or
should it be inferred from secret: Option<String> (won't scale well with other Authorization Flows)?

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/ramsayleung/rspotify/pull/151 **Author:** [@martinmake](https://github.com/martinmake) **Created:** 11/8/2020 **Status:** ❌ Closed **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (1) - [`904bab0`](https://github.com/ramsayleung/rspotify/commit/904bab0065fb3762ae3801d951dd731cc117dd8d) Initial draft ### 📊 Changes **3 files changed** (+78 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `Cargo.toml` (+6 -1) ➕ `examples/pkce_oauth_tokens.rs` (+59 -0) 📝 `src/oauth2.rs` (+13 -1) </details> ### 📄 Description I would start with a discussion about the user interface. I've added an example for this feature so we can have the same context. What do you think about it? Should we use: * `pub enum AuthorizationFlow` to choose between *Authorization Flows*, or * builders/functions, or * should it be inferred from `secret: Option<String>` (won't scale well with other *Authorization Flows*)? --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>