[PR #105] [MERGED] Upgraded dependencies #246

New issue

Closed

opened 2026-02-27 20:23:56 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 20:23:56 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/ramsayleung/rspotify/pull/105
Author: @marioortizmanero
Created: 8/12/2020
Status: ✅ Merged
Merged: 8/14/2020
Merged by: @ramsayleung

Base: master ← Head: master

📝 Commits (1)

8eb9291 Updated dependencies

📊 Changes

3 files changed (+21 additions, -15 deletions)

View changed files

📝 Cargo.toml (+13 -13)
📝 src/blocking/oauth2.rs (+4 -1)
📝 src/oauth2.rs (+4 -1)

📄 Description

I ran a cargo upgrade from cargo-edit to update the dependencies used in this module. I strongly suggest integrating Dependabot here so that this is taken care of automatically. It's really easy to use and avoids having to update all dependencies at once.

The only change I had to make so that the examples compiled was upgrading percent_encoding to v2.X. I simply followed the instructions indicated on their repo for the encoding set this module used.

On a side note: I think the base64 dependency may be unnecessary. I don't see where it's exactly being used, and the examples still compile after removing it from Cargo.toml and the extern crate from lib.rs.

Edit: please merge #106 first so that I can update this afterwards.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/ramsayleung/rspotify/pull/105 **Author:** [@marioortizmanero](https://github.com/marioortizmanero) **Created:** 8/12/2020 **Status:** ✅ Merged **Merged:** 8/14/2020 **Merged by:** [@ramsayleung](https://github.com/ramsayleung) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (1) - [`8eb9291`](https://github.com/ramsayleung/rspotify/commit/8eb929139fe661d8188e064b55adb769bb3bc23d) Updated dependencies ### 📊 Changes **3 files changed** (+21 additions, -15 deletions) <details> <summary>View changed files</summary> 📝 `Cargo.toml` (+13 -13) 📝 `src/blocking/oauth2.rs` (+4 -1) 📝 `src/oauth2.rs` (+4 -1) </details> ### 📄 Description I ran a `cargo upgrade` from `cargo-edit` to update the dependencies used in this module. I strongly suggest integrating [Dependabot](https://dependabot.com/) here so that this is taken care of automatically. It's really easy to use and avoids having to update all dependencies at once. The only change I had to make so that the examples compiled was upgrading `percent_encoding` to v2.X. I simply followed the instructions indicated [on their repo](https://github.com/servo/rust-url/blob/master/UPGRADING.md#upgrading-from-percent-encoding-1x-to-2x) for the [encoding set this module used](https://docs.diesel.rs/1.4.x/src/percent_encoding/lib.rs.html#143). On a side note: I think the `base64` dependency may be unnecessary. I don't see where it's exactly being used, and the examples still compile after removing it from `Cargo.toml` and the `extern crate` from `lib.rs`. Edit: please merge #106 first so that I can update this afterwards. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>