[PR #100] [MERGED] Dependencies cleanup #243

Closed
opened 2026-02-27 20:23:55 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/ramsayleung/rspotify/pull/100
Author: @marioortizmanero
Created: 7/2/2020
Status: Merged
Merged: 7/3/2020
Merged by: @ramsayleung

Base: masterHead: master


📝 Commits (1)

📊 Changes

1 file changed (+1 additions, -3 deletions)

View changed files

📝 Cargo.toml (+1 -3)

📄 Description

I was checking out the Cargo.toml file and found a couple dependencies useless, as they aren't used anywhere. random is a crate that hasn't been updated in four years, and I haven't found any matches of #[derive(Builder)], so it seems useless to me. I obtained these by running the following script I made:

#!/bin/sh

for name in base64 derive_builder dotenv env_logger itertools log percent-encoding rand random reqwest-default-tls reqwest-native-tls reqwest-native-tls-vendored reqwest-rustls-tls serde serde_derive serde_json url webbrowser lazy_static failure; do
    for pkg in "$name" $(echo "$name" | tr '-' '_'); do
        if grep -qrE "use $pkg|$pkg::|extern crate $pkg" src; then
            continue 2
        fi
    done

    echo "UNUSED $name"
done

I am completely new to the project, so if I'm wrong please let me know. Can anyone check if I missed any other useless dependencies?


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ramsayleung/rspotify/pull/100 **Author:** [@marioortizmanero](https://github.com/marioortizmanero) **Created:** 7/2/2020 **Status:** ✅ Merged **Merged:** 7/3/2020 **Merged by:** [@ramsayleung](https://github.com/ramsayleung) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (1) - [`bc44309`](https://github.com/ramsayleung/rspotify/commit/bc44309f8d42758611c048eadda7f6262fe1c46d) Dependencies cleanup ### 📊 Changes **1 file changed** (+1 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `Cargo.toml` (+1 -3) </details> ### 📄 Description I was checking out the `Cargo.toml` file and found a couple dependencies useless, as they aren't used anywhere. `random` is a crate that hasn't been updated in four years, and I haven't found any matches of `#[derive(Builder)]`, so it seems useless to me. I obtained these by running the following script I made: ```sh #!/bin/sh for name in base64 derive_builder dotenv env_logger itertools log percent-encoding rand random reqwest-default-tls reqwest-native-tls reqwest-native-tls-vendored reqwest-rustls-tls serde serde_derive serde_json url webbrowser lazy_static failure; do for pkg in "$name" $(echo "$name" | tr '-' '_'); do if grep -qrE "use $pkg|$pkg::|extern crate $pkg" src; then continue 2 fi done echo "UNUSED $name" done ``` I am completely new to the project, so if I'm wrong please let me know. Can anyone check if I missed any other useless dependencies? --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-27 20:23:55 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/rspotify#243
No description provided.