starred/rspotify

Fork 0

mirror of https://github.com/ramsayleung/rspotify.git synced 2026-04-26 07:55:55 +03:00

[GH-ISSUE #78] Add support for `async/await` #24

New issue

Closed

opened 2026-02-27 20:22:39 +03:00 by kerem · 10 comments

kerem commented

2026-02-27 20:22:39 +03:00

Owner

Originally created by @ghost on GitHub (Feb 23, 2020).
Original GitHub issue: https://github.com/ramsayleung/rspotify/issues/78

I tried to add support for async/await in my branch. I added an example (examples/async-artist-top-tracks) for it and went well.

If you have no future or ongoing plans to add support for async/await, please try my branch and leave me feedback.

Originally created by @ghost on GitHub (Feb 23, 2020). Original GitHub issue: https://github.com/ramsayleung/rspotify/issues/78 I tried to add support for `async/await` in my [branch](https://github.com/echoSayonara/rspotify/tree/support-for-async-await). I added an example (`examples/async-artist-top-tracks`) for it and went well. If you have no future or ongoing plans to add support for `async/await`, please try my branch and leave me feedback.

kerem closed this issue

2026-02-27 20:22:39 +03:00

kerem commented

2026-02-27 20:22:40 +03:00

Author

Owner

@ramsayleung commented on GitHub (Feb 23, 2020):

As for ongoing plan to support async/await, I have talked with the author of spotify-tui on this PR, and everything is working in process now. Because my full time job is so damn busy, I have to take some extra time to support async/await, so please be patient :)

@ramsayleung commented on GitHub (Feb 23, 2020): As for ongoing plan to support `async/await`, I have talked with the author of `spotify-tui` on this [PR](https://github.com/ramsayleung/rspotify/pull/72), and everything is working in process now. Because my full time job is so damn busy, I have to take some extra time to support `async/await`, so please be patient :)

kerem commented

2026-02-27 20:22:40 +03:00

Author

Owner

@ghost commented on GitHub (Feb 23, 2020):

Sorry, i did not mean to rush you.
Understood. I'm looking forward to it. I would like to be helpful for it if I can.

@ghost commented on GitHub (Feb 23, 2020): Sorry, i did not mean to rush you. Understood. I'm looking forward to it. I would like to be helpful for it if I can.

kerem commented

2026-02-27 20:22:40 +03:00

Author

Owner

@ramsayleung commented on GitHub (Feb 23, 2020):

I think your work/branch is inspired, there are a lot of things I could learn from your work. I just push my WIP work to remote origin. Instead of creating a nonblocking package, I prefer to create a blocking package, and make nonblocking default.

@ramsayleung commented on GitHub (Feb 23, 2020): I think your work/branch is inspired, there are a lot of things I could learn from your work. I just push my WIP work to [remote origin](https://github.com/ramsayleung/rspotify/tree/ramsay/support-for-async-await). Instead of creating a `nonblocking` package, I prefer to create a `blocking` package, and make `nonblocking` default.

kerem commented

2026-02-27 20:22:40 +03:00

Author

Owner

@ramsayleung commented on GitHub (Feb 23, 2020):

I would like to be helpful for it if I can.

If you have time, you could help me to convert those endpoint functions to async/await version, I just update the internal functions to async, there are still a lot of endpoint functions that needs to update.
github.com/ramsayleung/rspotify@2ed4705679/src/spotify/client.rs (L172)
github.com/ramsayleung/rspotify@2ed4705679/src/spotify/client.rs (L207)

@ramsayleung commented on GitHub (Feb 23, 2020): > I would like to be helpful for it if I can. If you have time, you could help me to convert those endpoint functions to `async/await` version, I just update the internal functions to `async`, there are still a lot of endpoint functions that needs to update. https://github.com/ramsayleung/rspotify/blob/2ed470567990e0c2241e88db9c79afc5566f9b01/src/spotify/client.rs#L172 https://github.com/ramsayleung/rspotify/blob/2ed470567990e0c2241e88db9c79afc5566f9b01/src/spotify/client.rs#L207

kerem commented

2026-02-27 20:22:40 +03:00

Author

Owner

@ghost commented on GitHub (Feb 24, 2020):

will do.

@ghost commented on GitHub (Feb 24, 2020): will do.

kerem commented

2026-02-27 20:22:40 +03:00

Author

Owner

@ramsayleung commented on GitHub (Feb 24, 2020):

I just submit all the work Rspotify needs to do to support async/await, if you have time to join me, feel free to check it The workload of adding support for async/await

@ramsayleung commented on GitHub (Feb 24, 2020): I just submit all the work `Rspotify` needs to do to support `async/await`, if you have time to join me, feel free to check it [The workload of adding support for `async/await`](https://github.com/ramsayleung/rspotify/issues/79)

kerem commented

2026-02-27 20:22:40 +03:00

Author

Owner

@ghost commented on GitHub (Feb 25, 2020):

I started to modify endpoint functions to support async/await in client.rs. I will send PR when i finished to implement them. Please wait.

@ghost commented on GitHub (Feb 25, 2020): I started to modify endpoint functions to support `async/await ` in `client.rs`. I will send PR when i finished to implement them. Please wait.

kerem commented

2026-02-27 20:22:40 +03:00

Author

Owner

@ramsayleung commented on GitHub (Feb 25, 2020):

Perhaps you could send a new PR once you have finished to implement a endpoint function, or you could mark which endpoint function you are going to modify? just in case of any conflicting situation that we are both modifying the same endpoint function.

@ramsayleung commented on GitHub (Feb 25, 2020): Perhaps you could send a new PR once you have finished to implement a endpoint function, or you could mark which endpoint function you are going to modify? just in case of any conflicting situation that we are both modifying the same endpoint function.

kerem commented

2026-02-27 20:22:40 +03:00

Author

Owner

@ghost commented on GitHub (Feb 25, 2020):

oh, it has already been implemented.

@ghost commented on GitHub (Feb 25, 2020): oh, it has already been implemented.

kerem commented

2026-02-27 20:22:40 +03:00

Author

Owner

@ramsayleung commented on GitHub (Feb 28, 2020):