[PR #84] [MERGED] Revert result conversion but make use of async/await #232

Closed
opened 2026-02-27 20:23:53 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/ramsayleung/rspotify/pull/84
Author: @Rigellute
Created: 2/25/2020
Status: Merged
Merged: 2/27/2020
Merged by: @ramsayleung

Base: ramsay/support-for-async-awaitHead: ramsay/support-for-async-await


📝 Commits (2)

  • 13983a7 Add json value deserialization to put
  • 2def685 Revert to previous result conversion but make async

📊 Changes

1 file changed (+236 additions, -144 deletions)

View changed files

📝 src/client.rs (+236 -144)

📄 Description

The pre-existing convert_result worked better for handling requests that have no response, so I've reverted to that implementation but added async/await again.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ramsayleung/rspotify/pull/84 **Author:** [@Rigellute](https://github.com/Rigellute) **Created:** 2/25/2020 **Status:** ✅ Merged **Merged:** 2/27/2020 **Merged by:** [@ramsayleung](https://github.com/ramsayleung) **Base:** `ramsay/support-for-async-await` ← **Head:** `ramsay/support-for-async-await` --- ### 📝 Commits (2) - [`13983a7`](https://github.com/ramsayleung/rspotify/commit/13983a792001fcc31299e1860ad1575be51df1b4) Add json value deserialization to put - [`2def685`](https://github.com/ramsayleung/rspotify/commit/2def68554cfb9344f1b7c6dc3a52e9cfd1b2420a) Revert to previous result conversion but make async ### 📊 Changes **1 file changed** (+236 additions, -144 deletions) <details> <summary>View changed files</summary> 📝 `src/client.rs` (+236 -144) </details> ### 📄 Description The pre-existing `convert_result` worked better for handling requests that have no response, so I've reverted to that implementation but added async/await again. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-27 20:23:53 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/rspotify#232
No description provided.