[PR #55] [MERGED] fix reqwest breaking change #210

New issue

Closed

opened 2026-02-27 20:23:47 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 20:23:47 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/ramsayleung/rspotify/pull/55
Author: @mainrs
Created: 9/30/2019
Status: ✅ Merged
Merged: 10/7/2019
Merged by: @ramsayleung

Base: master ← Head: fix_reqwest_version_break

📝 Commits (1)

1671189 fix reqwest breaking change

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 Cargo.toml (+1 -1)

📄 Description

As of v0.9.18, the reqwest dependency behaves differently and actually
crashes on usage. This commit fixes the version to the latest working
one, v0.9.17.

I have no idea why this is happening. I checked the commits between v0.9.17 and v0.9.18 (here) and the only one that stood out was this one. The commit message and the error I got in #54 sound feasible together.

The library is used within Spotifyd. We had a lot of issues opened whose source ultimately was rspotify. I could fix the errors we got by pinning down the version of reqwest in our Cargo.lock file to v0.9.17.

To prevent other people from stumbling across this problem, I opened this PR to pin the version down to v0.9.17 for now.

The error message I received got discussed here: https://github.com/seanmonstar/reqwest/issues/541. This comment draws attention to the problem that the patch version got updated with a breaking change. The issue creation date is 4 days after v0.9.18 released, so the comment is referring to that version tag.

There might be some larger refactoring needed for the long run. reqwest did huge changes to thee code on the master branch and even noted in the readme that the next release WILL break.

Closes #54.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/ramsayleung/rspotify/pull/55 **Author:** [@mainrs](https://github.com/mainrs) **Created:** 9/30/2019 **Status:** ✅ Merged **Merged:** 10/7/2019 **Merged by:** [@ramsayleung](https://github.com/ramsayleung) **Base:** `master` ← **Head:** `fix_reqwest_version_break` --- ### 📝 Commits (1) - [`1671189`](https://github.com/ramsayleung/rspotify/commit/1671189b240defb2e07d92648427d8424b083440) fix reqwest breaking change ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `Cargo.toml` (+1 -1) </details> ### 📄 Description As of v0.9.18, the reqwest dependency behaves differently and actually crashes on usage. This commit fixes the version to the latest working one, v0.9.17. I have no idea why this is happening. I checked the commits between v0.9.17 and v0.9.18 ([here](https://github.com/seanmonstar/reqwest/commits/v0.9.18)) and the only one that stood out was [this one](https://github.com/seanmonstar/reqwest/commit/5096e12fa21ffdf62ce953c7514e772959d1e4e1). The commit message and the error I got in #54 sound feasible together. The library is used within [Spotifyd](https://github.com/Spotifyd/spotifyd). We had a lot of issues opened whose source ultimately was `rspotify`. I could fix the errors we got by pinning down the version of reqwest in our `Cargo.lock` file to v0.9.17. To prevent other people from stumbling across this problem, I opened this PR to pin the version down to v0.9.17 for now. The error message I received got discussed here: https://github.com/seanmonstar/reqwest/issues/541. [This](https://github.com/seanmonstar/reqwest/issues/541#issuecomment-515753693) comment draws attention to the problem that the patch version got updated with a breaking change. The issue creation date is 4 days after v0.9.18 released, so the comment is referring to that version tag. There might be some larger refactoring needed for the long run. `reqwest` did huge changes to thee code on the master branch and even noted in the readme that the next release WILL break. Closes #54. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>