[PR #48] [MERGED] Remove an unnecessary mut from current_user_saved_tracks_delete #208

New issue

Closed

opened 2026-02-27 20:23:47 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 20:23:47 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/ramsayleung/rspotify/pull/48
Author: @togatoga
Created: 8/20/2019
Status: ✅ Merged
Merged: 8/22/2019
Merged by: @ramsayleung

Base: master ← Head: master

📝 Commits (1)

73ba040 Remove an unnecessary mut from current_user_saved_tracks_delete

📊 Changes

3 files changed (+4 additions, -4 deletions)

View changed files

📝 examples/current_user_saved_tracks_delete.rs (+1 -1)
📝 src/spotify/client.rs (+2 -2)
📝 tests/test_with_oauth.rs (+1 -1)

📄 Description

I found an unnecessary mut from current_user_saved_tracks_delete. It is better to change functions like current_user_saved_tracks_delete and current_user_saved_albums_delete to have similar arguments.

pub fn current_user_saved_albums_delete(&self, album_ids: &[String]) -> Result<(), failure::Error>
{
//..
}
pub fn current_user_saved_tracks_delete(&self, track_ids: &[String]) -> Result<(), failure::Error>
{
///..
}

I removed it and also modified example and test code.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/ramsayleung/rspotify/pull/48 **Author:** [@togatoga](https://github.com/togatoga) **Created:** 8/20/2019 **Status:** ✅ Merged **Merged:** 8/22/2019 **Merged by:** [@ramsayleung](https://github.com/ramsayleung) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (1) - [`73ba040`](https://github.com/ramsayleung/rspotify/commit/73ba040467a3890345ee124439efe7f3fa364975) Remove an unnecessary mut from current_user_saved_tracks_delete ### 📊 Changes **3 files changed** (+4 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `examples/current_user_saved_tracks_delete.rs` (+1 -1) 📝 `src/spotify/client.rs` (+2 -2) 📝 `tests/test_with_oauth.rs` (+1 -1) </details> ### 📄 Description I found an unnecessary `mut` from current_user_saved_tracks_delete. It is better to change functions like `current_user_saved_tracks_delete` and `current_user_saved_albums_delete` to have similar arguments. ```Rust pub fn current_user_saved_albums_delete(&self, album_ids: &[String]) -> Result<(), failure::Error> { //.. } pub fn current_user_saved_tracks_delete(&self, track_ids: &[String]) -> Result<(), failure::Error> { ///.. } ``` I removed it and also modified example and test code. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>