mirror of
https://github.com/ramsayleung/rspotify.git
synced 2026-04-26 16:05:53 +03:00
[GH-ISSUE #64] Track object missing images field #20
Labels
No labels
Stale
bug
discussion
enhancement
good first issue
good first issue
help wanted
pull-request
question
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/rspotify#20
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @SethGower on GitHub (Nov 11, 2019).
Original GitHub issue: https://github.com/ramsayleung/rspotify/issues/64
According to the reference for the track endpoint, one of the response fields is an array of
images, which can be empty, that just stores the album art for that song. Is there any reason this isn't implemented in here?@ramsayleung commented on GitHub (Nov 12, 2019):
Of course, there is no reason to not implement the
imagesfield. But it seems thetrack object (full)in the reference doesn't has key calledimages, but in the mockedresultof trace endpoint, it does has a key namedimages. Well, I am confused now, should I have theimagesfield or not ?@SethGower commented on GitHub (Nov 12, 2019):
I have tried testing it with calls, and there is a returned parameter for
images. I have gotten around it currently by just getting the image I want from going from track->album->image. I tried forking and implementing it myself. And was going to make a pull request. I am new to rust so it didn't work. But I may attempt again in the next couple of days if you don't get around to it.@SethGower commented on GitHub (Nov 12, 2019):
I just opened an issue on the GH issue tracker for the web-api.
@ramsayleung commented on GitHub (Nov 12, 2019):
It seems the
imagesfield is in thesimplified album object, but not in thefull trackobject, sorry for misleading you to the wrong way. Actual, there is a field namedimagesinsimplified album objectorfull album, I already have implemented it before.@SethGower commented on GitHub (Nov 12, 2019):
I realize it is in the Album object, that is what I am using in my app instead. But I still think it is an error with spotify's documentation that the
imagespart of the result for aFullTrackis missing.@marioortizmanero commented on GitHub (Nov 20, 2021):
I'll close this for now, since it seems that even with the new reference the
imagesfield isn't documented: https://developer.spotify.com/documentation/web-api/reference/#/operations/get-track. Even then, I haven't been able to reproduce it. And it seems to be a non-issue anyway.