[PR #31] [MERGED] Updated webbrowser dependency to fix issue on Windows #194

Closed
opened 2026-02-27 20:23:43 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/ramsayleung/rspotify/pull/31
Author: @mainrs
Created: 12/20/2018
Status: Merged
Merged: 12/24/2018
Merged by: @ramsayleung

Base: masterHead: master


📝 Commits (2)

  • e652489 fix windows browser opening by updating webbrowser dependency
  • 1ffaab4 bump version patch

📊 Changes

1 file changed (+2 additions, -2 deletions)

View changed files

📝 Cargo.toml (+2 -2)

📄 Description

I didn't run every single test as I had to manually allow every test to access my Spotify data but I did that for 10 tests and any test that didn't need the credentials passed too. Pretty sure this doesn't inflict anything else as it will just switch out the open logic for the webbrowser crate.

Closes #30.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ramsayleung/rspotify/pull/31 **Author:** [@mainrs](https://github.com/mainrs) **Created:** 12/20/2018 **Status:** ✅ Merged **Merged:** 12/24/2018 **Merged by:** [@ramsayleung](https://github.com/ramsayleung) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (2) - [`e652489`](https://github.com/ramsayleung/rspotify/commit/e65248950bed13c0a71881e17ecf623c9ef1bedd) fix windows browser opening by updating webbrowser dependency - [`1ffaab4`](https://github.com/ramsayleung/rspotify/commit/1ffaab4ca38ad8edc173c53005f2794b51dc539c) bump version patch ### 📊 Changes **1 file changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `Cargo.toml` (+2 -2) </details> ### 📄 Description I didn't run every single test as I had to manually allow every test to access my Spotify data but I did that for 10 tests and any test that didn't need the credentials passed too. Pretty sure this doesn't inflict anything else as it will just switch out the open logic for the webbrowser crate. Closes #30. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-27 20:23:43 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/rspotify#194
No description provided.