[PR #21] [MERGED] Feature fix devices #188

Closed
opened 2026-02-27 20:23:42 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/ramsayleung/rspotify/pull/21
Author: @ramsayleung
Created: 10/7/2018
Status: Merged
Merged: 10/7/2018
Merged by: @ramsayleung

Base: masterHead: feature-fix-devices


📝 Commits (7)

  • c94d561 update Cargo.lock
  • c2734a9 Merge branch 'master' of github.com:samrayleung/rspotify
  • 85c06a2 update rspotify to 0.2.5
  • 2684838 add Unknown field for DeviceType enum
  • a802a53 rename module test
  • 13e2225 add SpotifyClientCredentials debug info
  • 9d281d4 update CHANGELOG

📊 Changes

7 files changed (+72 additions, -54 deletions)

View changed files

📝 CHANGELOG.md (+7 -2)
📝 Cargo.toml (+1 -1)
📝 src/spotify/oauth2.rs (+2 -0)
📝 src/spotify/senum.rs (+1 -0)
tests/test_device.rs (+10 -0)
📝 tests/test_with_credential.rs (+3 -3)
📝 tests/test_with_oauth.rs (+48 -48)

📄 Description

  1. add new field Unknown for DeviceType enum
  2. TODO ignore failed test, fix them later

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ramsayleung/rspotify/pull/21 **Author:** [@ramsayleung](https://github.com/ramsayleung) **Created:** 10/7/2018 **Status:** ✅ Merged **Merged:** 10/7/2018 **Merged by:** [@ramsayleung](https://github.com/ramsayleung) **Base:** `master` ← **Head:** `feature-fix-devices` --- ### 📝 Commits (7) - [`c94d561`](https://github.com/ramsayleung/rspotify/commit/c94d56124778b1043a6a4008600deec14328640a) update Cargo.lock - [`c2734a9`](https://github.com/ramsayleung/rspotify/commit/c2734a982c23e3effbd37a74888901bc44f3e2cc) Merge branch 'master' of github.com:samrayleung/rspotify - [`85c06a2`](https://github.com/ramsayleung/rspotify/commit/85c06a29abfe6fc91b9121cb7a8be5fa601871df) update rspotify to 0.2.5 - [`2684838`](https://github.com/ramsayleung/rspotify/commit/268483898a6a37145ac6abd2546fbe4268224311) add `Unknown` field for `DeviceType` enum - [`a802a53`](https://github.com/ramsayleung/rspotify/commit/a802a53c1f1dd67b9bd7883176bbbb3f5b79940f) rename module test - [`13e2225`](https://github.com/ramsayleung/rspotify/commit/13e222582d8690379cb2f5ef17369573e0d253bd) add SpotifyClientCredentials debug info - [`9d281d4`](https://github.com/ramsayleung/rspotify/commit/9d281d4717ddf8ac9a61dc17c4bc3308f6ab9bb6) update CHANGELOG ### 📊 Changes **7 files changed** (+72 additions, -54 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELOG.md` (+7 -2) 📝 `Cargo.toml` (+1 -1) 📝 `src/spotify/oauth2.rs` (+2 -0) 📝 `src/spotify/senum.rs` (+1 -0) ➕ `tests/test_device.rs` (+10 -0) 📝 `tests/test_with_credential.rs` (+3 -3) 📝 `tests/test_with_oauth.rs` (+48 -48) </details> ### 📄 Description 1. add new field `Unknown` for `DeviceType` enum 2. TODO ignore failed test, fix them later --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-27 20:23:42 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/rspotify#188
No description provided.