[PR #11] [MERGED] OAuth get_authorize_url fixes #181

New issue

Closed

opened 2026-02-27 20:23:40 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 20:23:40 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/ramsayleung/rspotify/pull/11
Author: @oliveroneill
Created: 8/19/2018
Status: ✅ Merged
Merged: 8/19/2018
Merged by: @ramsayleung

Base: master ← Head: authorize-url-fixes

📝 Commits (3)

0e8b0b6 Fix typo in show_dialog
12e9cef Fix show_dialog field to be checked before setting true
bfee698 Change state field for authorization URL to have default

📊 Changes

1 file changed (+6 additions, -2 deletions)

View changed files

📝 src/spotify/oauth2.rs (+6 -2)

📄 Description

I've made a few changes to the get_authorize_url function so that it better matches the spotipy implementation. I believe this was the intention here but it had a few lines in need of improvement.

The changes are:

show_diaload changed to show_dialog. I believe this is a typo
state parameter falls back to self.state if None
show_dialog value is set before setting to "true" in parameters

I can split these changes up into multiple pull requests if necessary.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/ramsayleung/rspotify/pull/11 **Author:** [@oliveroneill](https://github.com/oliveroneill) **Created:** 8/19/2018 **Status:** ✅ Merged **Merged:** 8/19/2018 **Merged by:** [@ramsayleung](https://github.com/ramsayleung) **Base:** `master` ← **Head:** `authorize-url-fixes` --- ### 📝 Commits (3) - [`0e8b0b6`](https://github.com/ramsayleung/rspotify/commit/0e8b0b636bf4baa9f715e585bfdeaf19c629b2d4) Fix typo in show_dialog - [`12e9cef`](https://github.com/ramsayleung/rspotify/commit/12e9cef89dc1c0df41cf4ef2c7eecda4d4e915a2) Fix show_dialog field to be checked before setting true - [`bfee698`](https://github.com/ramsayleung/rspotify/commit/bfee698d30e5df9486dedc0e3d5ba69720f8334f) Change state field for authorization URL to have default ### 📊 Changes **1 file changed** (+6 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/spotify/oauth2.rs` (+6 -2) </details> ### 📄 Description I've made a few changes to the get_authorize_url function so that it better matches the spotipy implementation. I believe this was the intention here but it had a few lines in need of improvement. The changes are: - show_diaload changed to show_dialog. I believe this is a typo - state parameter falls back to self.state if None - show_dialog value is set before setting to "true" in parameters I can split these changes up into multiple pull requests if necessary. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>