[PR #5] [MERGED] Fix failing tests #178

New issue

Closed

opened 2026-02-27 20:23:39 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 20:23:39 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/ramsayleung/rspotify/pull/5
Author: @DomWilliams0
Created: 5/15/2018
Status: ✅ Merged
Merged: 5/16/2018
Merged by: @ramsayleung

Base: master ← Head: master

📝 Commits (4)

bd817f1 Fix typo in AlbumType enum
6959a16 Remove empty body from GET requests
c508f0c Fix panic in parsing of empty token code
e45793b Update Cargo.lock version

📊 Changes

4 files changed (+27 additions, -21 deletions)

View changed files

📝 Cargo.lock (+1 -1)
📝 src/spotify/client.rs (+19 -12)
📝 src/spotify/oauth2.rs (+3 -4)
📝 src/spotify/senum.rs (+4 -4)

📄 Description

I fixed a few issues that were preventing the tests from passing:

GET requests with a body are rejected by Spotify with a 400 response - even {}
If the argument to parse_response_code is an empty string, the function panics
A typo in "compilation" causes deserialisation to fail

Cargo also keeps trying to update the version in Cargo.lock to 0.1.2, so I commited that too :)

Thanks a lot for this library, it has saved me a lot of time! 💯

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/ramsayleung/rspotify/pull/5 **Author:** [@DomWilliams0](https://github.com/DomWilliams0) **Created:** 5/15/2018 **Status:** ✅ Merged **Merged:** 5/16/2018 **Merged by:** [@ramsayleung](https://github.com/ramsayleung) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (4) - [`bd817f1`](https://github.com/ramsayleung/rspotify/commit/bd817f1d68dce26192a9eb9d884a5d024e68d451) Fix typo in AlbumType enum - [`6959a16`](https://github.com/ramsayleung/rspotify/commit/6959a16e6844fcb8264c05ad4d2bf12d2251c69b) Remove empty body from GET requests - [`c508f0c`](https://github.com/ramsayleung/rspotify/commit/c508f0c2643137585a4073211ecda46f09d9ba1f) Fix panic in parsing of empty token code - [`e45793b`](https://github.com/ramsayleung/rspotify/commit/e45793b719cdf067380c558863c1dc23b2bfc2d3) Update Cargo.lock version ### 📊 Changes **4 files changed** (+27 additions, -21 deletions) <details> <summary>View changed files</summary> 📝 `Cargo.lock` (+1 -1) 📝 `src/spotify/client.rs` (+19 -12) 📝 `src/spotify/oauth2.rs` (+3 -4) 📝 `src/spotify/senum.rs` (+4 -4) </details> ### 📄 Description I fixed a few issues that were preventing the tests from passing: - GET requests with a body are rejected by Spotify with a 400 response - even `{}` - If the argument to `parse_response_code` is an empty string, the function panics - A typo in "compilation" causes deserialisation to fail Cargo also keeps trying to update the version in `Cargo.lock` to 0.1.2, so I commited that too :) Thanks a lot for this library, it has saved me a lot of time! :100: --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>