[PR #8] [MERGED] replace error_chain crate with failure crate for error handling #177

Closed
opened 2026-02-27 20:23:39 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/ramsayleung/rspotify/pull/8
Author: @maxjoehnk
Created: 6/12/2018
Status: Merged
Merged: 6/13/2018
Merged by: @ramsayleung

Base: masterHead: feature/failure-errors


📝 Commits (1)

  • c923653 replace error_chain crate with failure crate for error handling

📊 Changes

5 files changed (+101 additions, -91 deletions)

View changed files

📝 Cargo.lock (+27 -5)
📝 Cargo.toml (+1 -1)
src/errors.rs (+0 -10)
📝 src/lib.rs (+1 -3)
📝 src/spotify/client.rs (+72 -72)

📄 Description

This change replaces the error_chain crate with the failure crate.
Primary reason for this change is that the old implementation isn't sync and therefore can't be sent between threads.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ramsayleung/rspotify/pull/8 **Author:** [@maxjoehnk](https://github.com/maxjoehnk) **Created:** 6/12/2018 **Status:** ✅ Merged **Merged:** 6/13/2018 **Merged by:** [@ramsayleung](https://github.com/ramsayleung) **Base:** `master` ← **Head:** `feature/failure-errors` --- ### 📝 Commits (1) - [`c923653`](https://github.com/ramsayleung/rspotify/commit/c923653f325e4e43fcc256e25a6d99ac13f30ccd) replace error_chain crate with failure crate for error handling ### 📊 Changes **5 files changed** (+101 additions, -91 deletions) <details> <summary>View changed files</summary> 📝 `Cargo.lock` (+27 -5) 📝 `Cargo.toml` (+1 -1) ➖ `src/errors.rs` (+0 -10) 📝 `src/lib.rs` (+1 -3) 📝 `src/spotify/client.rs` (+72 -72) </details> ### 📄 Description This change replaces the error_chain crate with the failure crate. Primary reason for this change is that the old implementation isn't sync and therefore can't be sent between threads. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-27 20:23:39 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/rspotify#177
No description provided.