mirror of
https://github.com/ramsayleung/rspotify.git
synced 2026-04-26 07:55:55 +03:00
[GH-ISSUE #59] Using proxy #16
Labels
No labels
Stale
bug
discussion
enhancement
good first issue
good first issue
help wanted
pull-request
question
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/rspotify#16
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @conilas on GitHub (Oct 16, 2019).
Original GitHub issue: https://github.com/ramsayleung/rspotify/issues/59
Hey there!
I tried to use spotify-tui (which apparently uses this library) inside my company, where everything runs behind a proxy. After a little digging, I noticed they were trying to get the json token for oauth (https://github.com/ramsayleung/rspotify/blob/master/src/spotify/oauth2.rs), but the client from reqwest is being built without the proxy.
They have a good doc on it (https://docs.rs/reqwest/0.7.0/reqwest/struct.Proxy.html), so I was able to change the Client building line the proxy.
Question is: do you guys plan to have any take on that? I might be able to make a PR if that is not/not supposed to be in the roadmap or anything.
Thanks!
@ramsayleung commented on GitHub (Oct 16, 2019):
PR is certainly welcome, It frustrated that I don't have time to add proxy feature to rspotify now, hence it's great if you could contribute to it.
@ramsayleung commented on GitHub (Jan 20, 2020):
I have updated
reqwestto the latest version, now rspotify supports system proxy by default(Notes thatcheck this issue for more details). For more details, please check this PR https://github.com/ramsayleung/rspotify/pull/70.reqwestsystem proxy doesn't support socks proxy for now,imageendpoints for playlists #115