[GH-ISSUE #59] Using proxy #16

Closed
opened 2026-02-27 20:22:37 +03:00 by kerem · 2 comments
Owner

Originally created by @conilas on GitHub (Oct 16, 2019).
Original GitHub issue: https://github.com/ramsayleung/rspotify/issues/59

Hey there!

I tried to use spotify-tui (which apparently uses this library) inside my company, where everything runs behind a proxy. After a little digging, I noticed they were trying to get the json token for oauth (https://github.com/ramsayleung/rspotify/blob/master/src/spotify/oauth2.rs), but the client from reqwest is being built without the proxy.

They have a good doc on it (https://docs.rs/reqwest/0.7.0/reqwest/struct.Proxy.html), so I was able to change the Client building line the proxy.

Question is: do you guys plan to have any take on that? I might be able to make a PR if that is not/not supposed to be in the roadmap or anything.

Thanks!

Originally created by @conilas on GitHub (Oct 16, 2019). Original GitHub issue: https://github.com/ramsayleung/rspotify/issues/59 Hey there! I tried to use spotify-tui (which apparently uses this library) inside my company, where everything runs behind a proxy. After a little digging, I noticed they were trying to get the json token for oauth (https://github.com/ramsayleung/rspotify/blob/master/src/spotify/oauth2.rs), but the client from reqwest is being built without the proxy. They have a good doc on it (https://docs.rs/reqwest/0.7.0/reqwest/struct.Proxy.html), so I was able to change the Client building line the proxy. Question is: do you guys plan to have any take on that? I might be able to make a PR if that is not/not supposed to be in the roadmap or anything. Thanks!
kerem closed this issue 2026-02-27 20:22:37 +03:00
Author
Owner

@ramsayleung commented on GitHub (Oct 16, 2019):

PR is certainly welcome, It frustrated that I don't have time to add proxy feature to rspotify now, hence it's great if you could contribute to it.

<!-- gh-comment-id:542575645 --> @ramsayleung commented on GitHub (Oct 16, 2019): PR is certainly welcome, It frustrated that I don't have time to add proxy feature to rspotify now, hence it's great if you could contribute to it.
Author
Owner

@ramsayleung commented on GitHub (Jan 20, 2020):

I have updated reqwest to the latest version, now rspotify supports system proxy by default(Notes that reqwest system proxy doesn't support socks proxy for now, check this issue for more details). For more details, please check this PR https://github.com/ramsayleung/rspotify/pull/70.

<!-- gh-comment-id:576093976 --> @ramsayleung commented on GitHub (Jan 20, 2020): I have updated `reqwest` to the latest version, now rspotify supports system proxy by default(~~Notes that `reqwest` system proxy doesn't support socks proxy for now,~~ check [this issue](https://github.com/seanmonstar/reqwest/issues/790) for more details). For more details, please check this PR https://github.com/ramsayleung/rspotify/pull/70.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/rspotify#16
No description provided.