mirror of
https://github.com/ramsayleung/rspotify.git
synced 2026-04-26 07:55:55 +03:00
[GH-ISSUE #37] Null-value for album_type prevents parsing #15
Labels
No labels
Stale
bug
discussion
enhancement
good first issue
good first issue
help wanted
pull-request
question
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/rspotify#15
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @hrkfdn on GitHub (Mar 22, 2019).
Original GitHub issue: https://github.com/ramsayleung/rspotify/issues/37
I have already reported this upstream. but I doubt it'll be addressed anytime soon, if at all.
It seems that, unlike stated by the documentation,
album_typecan benullfor local tracks. This causes parsing errors in rspotify. We could either transformalbum_typein our struct to anOption, or set it to an empty string for these cases. I'm guessing the latter would be better as it won't break API, but the former seems more correct?