{id}` requires market query parameter but `get_a_show` market parameter is `Option` #147

New issue

Closed

opened 2026-02-27 20:23:23 +03:00 by kerem · 2 comments

kerem commented

2026-02-27 20:23:23 +03:00

Owner

Originally created by @oSumAtrIX on GitHub (Sep 13, 2023).
Original GitHub issue: https://github.com/ramsayleung/rspotify/issues/442

Spotify documents that the route /v1/shows/{id} requires a market query parameter but get_a_show market parameter is Option. If None is supplied, the request will fail with status code 404 as documented.

Originally created by @oSumAtrIX on GitHub (Sep 13, 2023). Original GitHub issue: https://github.com/ramsayleung/rspotify/issues/442 Spotify [documents](https://developer.spotify.com/documentation/web-api/reference/get-a-show) that the route `/v1/shows/{id}` **requires** a market query parameter but `get_a_show` market parameter is `Option`. If `None` is supplied, the request will fail with status code `404` as documented.

kerem

2026-02-27 20:23:23 +03:00

closed this issue
added the
help wanted

bug
labels

kerem commented

2026-02-27 20:23:24 +03:00

Author

Owner

@ramsayleung commented on GitHub (Sep 13, 2023):

The document doesn't mark the market parameter as required.

If None is supplied, the request will fail with status code 404 as documented

From the document, it's by design:

Note: If neither market or user country are provided, the content is considered unavailable for the client.
Users can view the country that is associated with their account in the account settings.

I could remove the option field, and mark the market as required

@ramsayleung commented on GitHub (Sep 13, 2023): The document doesn't mark the `market` parameter as `required`. > If None is supplied, the request will fail with status code 404 as documented From the document, it's by design: > Note: If neither market or user country are provided, the content is considered unavailable for the client. Users can view the country that is associated with their account in the [account settings](https://www.spotify.com/se/account/overview/). I could remove the option field, and mark the market as `required`

kerem commented

2026-02-27 20:23:24 +03:00

Author

Owner

@oSumAtrIX commented on GitHub (Sep 13, 2023):

I understand where you are coming from. The documentation indeed treats it as optional, thus the implementation reflects the correct design.

@oSumAtrIX commented on GitHub (Sep 13, 2023): I understand where you are coming from. The documentation indeed treats it as optional, thus the implementation reflects the correct design.