mirror of
https://github.com/ramsayleung/rspotify.git
synced 2026-04-25 23:45:52 +03:00
[GH-ISSUE #425] Yank version 0.11.7 from crates.io #142
Labels
No labels
Stale
bug
discussion
enhancement
good first issue
good first issue
help wanted
pull-request
question
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/rspotify#142
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @ThomasFrans on GitHub (Jun 6, 2023).
Original GitHub issue: https://github.com/ramsayleung/rspotify/issues/425
Describe the bug
There seemed to have been a breaking change in one of the playlist methods (use of duration instead of an integer) which made its way onto crates.io. Some people are experiencing issues when installing other programs using that version. I wonder whether it would make sense to yank it as that would prevent these issues. It would still allow crates that are already using it to keep using the yanked version, but would prevent further confusion.
Expected behavior
Minor version increases should not have breaking API changes. A new version could be published with a major version increase (which is recommended by the semantic versioning standard when there is an unexpected breaking change). I think the breaking change has already been resolved so this major version increase wouldn't be needed.
Additional Context
I hope it's OK to suggest this. It's not fun to yank a release, but since it can cause confusion and is already confusing some people when they use
cargo installwithout adding--locked, it would make sense to prevent this. 🙂@ramsayleung commented on GitHub (Jun 7, 2023):
Hi Thomas, thanks for your suggestion, I think your point makes sense and reasonable, this library introduces some breaking API changes, so it shouldn't be a minor version increase, and it also introduces a fatal problem with the playlist method, so the v0.11.7 should be yanked from crates.io.
But I think a better solution is releasing a new version like
v0.12before yanking the v0.11.7 version, so other developers are able to upgrade to the latest version.I would like to publish a new version after merging these two PRs:
@github-actions[bot] commented on GitHub (Dec 5, 2023):
Message to comment on stale issues. If none provided, will not mark issues stale
@ramsayleung commented on GitHub (Mar 12, 2024):
Closing this issue since the v0.11.7 has been yanked.