starred/rspotify

Fork 0

mirror of https://github.com/ramsayleung/rspotify.git synced 2026-04-25 23:45:52 +03:00

[GH-ISSUE #414] Uri enum #138

New issue

Closed

opened 2026-02-27 20:23:20 +03:00 by kerem · 5 comments

kerem commented

2026-02-27 20:23:20 +03:00

Owner

Originally created by @blueforesticarus on GitHub (May 25, 2023).
Original GitHub issue: https://github.com/ramsayleung/rspotify/issues/414

Is your feature request related to a problem? Please describe.
I am making a cli for testing parts of my application and want to pass a spotify uri as an arg. A way to parse this as a valid spotify uri, then match on it, would be useful. It would also serve as a useful type for parts of my application which are generic over Album, Playlist, or Track, of which there are many.

Describe the solution you'd like
It would be convenient to have an Uri enum covering all the Id types, so we can always parse a uri, and match over the various ids.

Describe alternatives you've considered
Manually calling parse_uri and matching over the result.
Alternatively Uri could be a struct with id and type. Though I think this is maybe more cumbersome for matching.

Originally created by @blueforesticarus on GitHub (May 25, 2023). Original GitHub issue: https://github.com/ramsayleung/rspotify/issues/414 **Is your feature request related to a problem? Please describe.** I am making a cli for testing parts of my application and want to pass a spotify uri as an arg. A way to parse this as a valid spotify uri, then match on it, would be useful. It would also serve as a useful type for parts of my application which are generic over Album, Playlist, or Track, of which there are many. **Describe the solution you'd like** It would be convenient to have an Uri enum covering all the Id types, so we can always parse a uri, and match over the various ids. **Describe alternatives you've considered** Manually calling parse_uri and matching over the result. Alternatively Uri could be a struct with id and type. Though I think this is maybe more cumbersome for matching.

kerem

2026-02-27 20:23:20 +03:00

closed this issue
added the
enhancement

Stale
labels

kerem commented

2026-02-27 20:23:21 +03:00

Author

Owner

@ramsayleung commented on GitHub (May 25, 2023):

Please follow the issue template to describe your problem with context information, it would be helpful for others to understand your issue.

@ramsayleung commented on GitHub (May 25, 2023): Please follow the issue template to describe your problem with context information, it would be helpful for others to understand your issue.

kerem commented

2026-02-27 20:23:21 +03:00

Author

Owner

@blueforesticarus commented on GitHub (May 26, 2023):

I think this is a sufficient implementation for what I am talking about (if you agree it is desirable). Although someone may have suggestions.

Someone could argue that Uri should be a struct with id and type, perhaps with another type for the enum.

@blueforesticarus commented on GitHub (May 26, 2023): I think this is a sufficient implementation for what I am talking about (if you agree it is desirable). Although someone may have suggestions. Someone could argue that Uri should be a struct with id and type, perhaps with another type for the enum.

kerem commented

2026-02-27 20:23:21 +03:00

Author

Owner

@ramsayleung commented on GitHub (Jun 7, 2023):

I think it makes sense to me, feel free to create a PR :)

@ramsayleung commented on GitHub (Jun 7, 2023): I think it makes sense to me, feel free to create a PR :)

kerem commented

2026-02-27 20:23:21 +03:00

Author

Owner

@github-actions[bot] commented on GitHub (Dec 5, 2023):

Message to comment on stale issues. If none provided, will not mark issues stale

@github-actions[bot] commented on GitHub (Dec 5, 2023): Message to comment on stale issues. If none provided, will not mark issues stale

kerem commented

2026-02-27 20:23:21 +03:00

Author

Owner

@github-actions[bot] commented on GitHub (Nov 28, 2025):

Message to comment on stale issues. If none provided, will not mark issues stale

@github-actions[bot] commented on GitHub (Nov 28, 2025): Message to comment on stale issues. If none provided, will not mark issues stale

kerem referenced this issue

2026-02-27 20:24:00 +03:00

[PR #138] [CLOSED] Update tokio requirement from 0.2.22 to 0.3.0 #263