starred/rspotify
1
0
Fork 0
mirror of https://github.com/ramsayleung/rspotify.git synced 2026-04-25 23:45:52 +03:00
Code Issues 15 Projects Releases 5 Packages Wiki Activity

[GH-ISSUE #411] PlaylistItem.track possibly shouldn't be wrapped in Option #135

New issue
Closed
opened 2026-02-27 20:23:19 +03:00 by kerem · 3 comments
kerem commented 2026-02-27 20:23:19 +03:00
Owner
Copy link

Originally created by @kangalio on GitHub (May 18, 2023).
Original GitHub issue: https://github.com/ramsayleung/rspotify/issues/411

At least when returned from Get Playlist, the field is never absent:

Screenshot_20230519_014641

Link

I'm not sure which other endpoints return payloads containing PlaylistItem - if PlaylistItem.track is optional in any of those, we probably shouldn't duplicate PlaylistItem and instead add a doc comment to BaseClient.playlist(): "the [`PlaylistItem::track`] field in this response is always Some".

Originally created by @kangalio on GitHub (May 18, 2023). Original GitHub issue: https://github.com/ramsayleung/rspotify/issues/411 At least when returned from Get Playlist, the field is never absent: ![Screenshot_20230519_014641](https://github.com/ramsayleung/rspotify/assets/21220820/887c4f4b-7cff-4743-a760-954dec3d8f7d) [Link](https://developer.spotify.com/documentation/web-api/reference/get-playlist) I'm not sure which other endpoints return payloads containing PlaylistItem - if PlaylistItem.track _is_ optional in any of those, we probably shouldn't duplicate PlaylistItem and instead add a doc comment to BaseClient.playlist(): "the \[\`PlaylistItem::track\`\] field in this response is always Some".
kerem 2026-02-27 20:23:19 +03:00
kerem commented 2026-02-27 20:23:20 +03:00
Author
Owner
Copy link

@github-actions[bot] commented on GitHub (Nov 15, 2023):

Message to comment on stale issues. If none provided, will not mark issues stale

<!-- gh-comment-id:1811687912 --> @github-actions[bot] commented on GitHub (Nov 15, 2023): Message to comment on stale issues. If none provided, will not mark issues stale
kerem commented 2026-02-27 20:23:20 +03:00
Author
Owner
Copy link

@kangalio commented on GitHub (Nov 30, 2023):

Another valid inprovement suggestion lost to the relentless bug report steamroller called stale bot :'(

<!-- gh-comment-id:1833444728 --> @kangalio commented on GitHub (Nov 30, 2023): Another valid inprovement suggestion lost to the relentless bug report steamroller called stale bot :'(
kerem commented 2026-02-27 20:23:20 +03:00
Author
Owner
Copy link

@github-actions[bot] commented on GitHub (Nov 28, 2025):

Message to comment on stale issues. If none provided, will not mark issues stale

<!-- gh-comment-id:3587752603 --> @github-actions[bot] commented on GitHub (Nov 28, 2025): Message to comment on stale issues. If none provided, will not mark issues stale
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
master
ramsay/upgrade-0.16.1
dependabot/cargo/sha2-0.11.0
ramsay/upgrade-to-v0.16
ramsay/deprecate-removed-renamed-field
ramsay/migrate-to-new-endpoint
ramsay/deprecate-removed-endpoints
dependabot/cargo/strum-0.28.0
dependabot/cargo/reqwest-middleware-0.5.1
dependabot/cargo/reqwest-0.13.1
ramsay/upgrade-to-0.15.3
ramsay/upgrade-to-0.15.2
dependabot/cargo/ureq-3.1.2
ramsay/upgrade-dependencies
ramsay/upgrade-to-0.15.1
ramsay/fix-malformed-json
ramsay/upgrade-to-v0.15.0
ramsay/allow-enum-unknown-variant
ramsay/upgrade-to-0.14
ramsay/add_tcplistern_for_callback
ramsay/fix-clippy-error
ramsay/update-doc
ramsay/fix-endless-sequence
ramsay/publish-crate-workflow-test
ramsay/fix-pkce-refresh-token
ramsay/pkce_auth_refresh_token
ramsay_add_test_for_collectionyourepisodes
better-webapp
ramsay_fix_token_expired
percent-search
refresh_token_rwlock
ramsay_convert_result_inside_endpoint
streaming
v0.16.1
v0.16.0
v0.15.3
v0.15.2
v0.15.1
v0.15.0
v0.14.0
v0.13.3
v0.13.2
v0.13.1
v0.13.0
v0.12.0
v0.11.7
v0.11.6
v0.10.0
v0.11.5
v0.11.5.0
v0.11.4
v0.11.3
v0.11.2
v0.11.1
v0.11.0
v0.11.5.1
v0.9
v0.9-alpha
Labels
Clear labels   
Stale

   
bug

   
discussion

   
enhancement

   
good first issue

   
good first issue

   
help wanted

   
pull-request

Mirrored from GitHub Pull Request

  
question
No labels
Stale
bug
discussion
enhancement
good first issue
good first issue
help wanted
pull-request
question
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/rspotify#135
No description provided.