[PR #25] fix: add SOCKS4 for CONNECT #24

Open
opened 2026-03-01 14:36:00 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/alpkeskin/rota/pull/25
Author: @HellLord77
Created: 2/20/2026
Status: 🔄 Open

Base: mainHead: socks4


📝 Commits (2)

  • d46d2ea fix: add missing SOCKS4 for CONNECT
  • c8343ab feat: simplify socks dialer

📊 Changes

4 files changed (+52 additions, -102 deletions)

View changed files

📝 core/go.mod (+1 -1)
📝 core/internal/models/proxy.go (+37 -20)
📝 core/internal/proxy/handler.go (+7 -26)
📝 core/internal/proxy/transport.go (+7 -55)

📄 Description

currently only GET can handle SOCKS4
this pr adds SOCKS4 support when using CONNECT


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/alpkeskin/rota/pull/25 **Author:** [@HellLord77](https://github.com/HellLord77) **Created:** 2/20/2026 **Status:** 🔄 Open **Base:** `main` ← **Head:** `socks4` --- ### 📝 Commits (2) - [`d46d2ea`](https://github.com/alpkeskin/rota/commit/d46d2ea817d75eaf4b22b0d11189046c4a5f339d) fix: add missing SOCKS4 for CONNECT - [`c8343ab`](https://github.com/alpkeskin/rota/commit/c8343ab5461d68935b62f01d8311bdce288fc8df) feat: simplify socks dialer ### 📊 Changes **4 files changed** (+52 additions, -102 deletions) <details> <summary>View changed files</summary> 📝 `core/go.mod` (+1 -1) 📝 `core/internal/models/proxy.go` (+37 -20) 📝 `core/internal/proxy/handler.go` (+7 -26) 📝 `core/internal/proxy/transport.go` (+7 -55) </details> ### 📄 Description currently only GET can handle SOCKS4 this pr adds SOCKS4 support when using CONNECT --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/rota#24
No description provided.