[PR #7] [MERGED] feat(proxy): Add support for a cert storage #18

New issue

Closed

opened 2026-03-01 14:35:59 +03:00 by kerem · 0 comments

kerem commented

2026-03-01 14:35:59 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/alpkeskin/rota/pull/7
Author: @Fijxu
Created: 1/12/2025
Status: ✅ Merged
Merged: 1/13/2025
Merged by: @alpkeskin

Base: main ← Head: cert-storage

📝 Commits (1)

ef0b9a6 feat(proxy): Add support for a cert storage

📊 Changes

2 files changed (+38 additions, -0 deletions)

View changed files

➕ internal/proxy/cert_storage.go (+37 -0)
📝 internal/proxy/proxy.go (+1 -0)

📄 Description

When doing a lot of requests using rota, the CPU usage was insanely high, this is due to goproxy generating a new certificate on each request for the domain requested.

To solve this I just implemented this simple example from the goproxy repo: https://github.com/elazarl/goproxy/tree/master/examples/certstorage

References: https://github.com/elazarl/goproxy/issues/430

Feel free to close it if you want to implement it in your own way. You can try it by pulling https://git.nadeko.net/Fijxu/-/packages/container/rota/cert-storage ( docker pull git.nadeko.net/fijxu/rota:cert-storage )

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/alpkeskin/rota/pull/7 **Author:** [@Fijxu](https://github.com/Fijxu) **Created:** 1/12/2025 **Status:** ✅ Merged **Merged:** 1/13/2025 **Merged by:** [@alpkeskin](https://github.com/alpkeskin) **Base:** `main` ← **Head:** `cert-storage` --- ### 📝 Commits (1) - [`ef0b9a6`](https://github.com/alpkeskin/rota/commit/ef0b9a67454d02e4011e6e094e81b7f44e43c9a0) feat(proxy): Add support for a cert storage ### 📊 Changes **2 files changed** (+38 additions, -0 deletions) <details> <summary>View changed files</summary> ➕ `internal/proxy/cert_storage.go` (+37 -0) 📝 `internal/proxy/proxy.go` (+1 -0) </details> ### 📄 Description When doing a lot of requests using rota, the CPU usage was insanely high, this is due to goproxy generating a new certificate on each request for the domain requested. To solve this I just implemented this simple example from the goproxy repo: https://github.com/elazarl/goproxy/tree/master/examples/certstorage References: https://github.com/elazarl/goproxy/issues/430 Feel free to close it if you want to implement it in your own way. You can try it by pulling https://git.nadeko.net/Fijxu/-/packages/container/rota/cert-storage ( `docker pull git.nadeko.net/fijxu/rota:cert-storage` ) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>