[PR #38] [MERGED] [Feature] Add cross site scripting #56

New issue

Closed

opened 2026-03-02 02:13:00 +03:00 by kerem · 0 comments

kerem commented

2026-03-02 02:13:00 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/amidaware/rmmagent/pull/38
Author: @NiceGuyIT
Created: 11/12/2023
Status: ✅ Merged
Merged: 2/22/2024
Merged by: @wh1te909

Base: develop ← Head: feature/cross-platform-scripting

📝 Commits (3)

6ba3272 [Feature] Add cross site scripting
87e1b29 Add: Download the nu and deno binaries from GitHub
2afdfd7 Add: Server variables are opt-out by default

📊 Changes

13 files changed (+923 additions, -72 deletions)

View changed files

📝 agent/agent.go (+22 -0)
📝 agent/agent_unix.go (+380 -4)
📝 agent/agent_windows.go (+330 -1)
📝 agent/checks.go (+1 -1)
📝 agent/choco_windows.go (+1 -1)
📝 agent/embed_darwin.go (+1 -1)
📝 agent/install.go (+10 -2)
📝 agent/rpc.go (+24 -18)
📝 agent/svc.go (+45 -10)
📝 agent/tasks_windows.go (+2 -2)
📝 agent/utils.go (+67 -0)
📝 main.go (+4 -0)
📝 shared/types.go (+36 -32)

📄 Description

This PR adds support for Nushell and Deno to provide a cross platform scripting environments.

Associated PRs

rmmagent: amidaware/rmmagent#38
tacticalrmm: amidaware/tacticalrmm#1676
tacticalrmm-web: amidaware/tacticalrmm-web#14
trmm-docs: amidaware/trmm-docs#217
community-scripts: TBD

Questions

macOS uses /opt/tacticalagent but Linux does not. Should this be created to hold the nu and deno binaries?
- Added /opt/tacticalagent to the Linux agent and uninstall script.
Should the *nix binaries reside in /opt/tacticalagent/bin/? I noticed the Mac agent is in /opt/tacticalagent/tacticalagent and stores old versions as *-v1.2.3.
- Yes.

Out of scope.

macOS: /opt/tacticalagent permissions (o-rwx, 0x750) do not permit reading by the user. When Run As User is implemented for Mac/Linux, this will need to be changed.
- A fresh install has the correct permissions. This should not be an issue.

TODO

These items are done.

Download and uncompress the files from GitHub
Save them in Tactical's "bin" directory (platform dependent).

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/amidaware/rmmagent/pull/38 **Author:** [@NiceGuyIT](https://github.com/NiceGuyIT) **Created:** 11/12/2023 **Status:** ✅ Merged **Merged:** 2/22/2024 **Merged by:** [@wh1te909](https://github.com/wh1te909) **Base:** `develop` ← **Head:** `feature/cross-platform-scripting` --- ### 📝 Commits (3) - [`6ba3272`](https://github.com/amidaware/rmmagent/commit/6ba3272dc0126bf4a5c4b0e8b17597de4446858c) [Feature] Add cross site scripting - [`87e1b29`](https://github.com/amidaware/rmmagent/commit/87e1b29ef6e203d5e72f72f4203b5941e2eb79b7) Add: Download the nu and deno binaries from GitHub - [`2afdfd7`](https://github.com/amidaware/rmmagent/commit/2afdfd7ab88083b27d42898dd2ffe1adf3868c4b) Add: Server variables are opt-out by default ### 📊 Changes **13 files changed** (+923 additions, -72 deletions) <details> <summary>View changed files</summary> 📝 `agent/agent.go` (+22 -0) 📝 `agent/agent_unix.go` (+380 -4) 📝 `agent/agent_windows.go` (+330 -1) 📝 `agent/checks.go` (+1 -1) 📝 `agent/choco_windows.go` (+1 -1) 📝 `agent/embed_darwin.go` (+1 -1) 📝 `agent/install.go` (+10 -2) 📝 `agent/rpc.go` (+24 -18) 📝 `agent/svc.go` (+45 -10) 📝 `agent/tasks_windows.go` (+2 -2) 📝 `agent/utils.go` (+67 -0) 📝 `main.go` (+4 -0) 📝 `shared/types.go` (+36 -32) </details> ### 📄 Description This PR adds support for [Nushell](https://www.nushell.sh/) and [Deno](https://deno.land/) to provide a cross platform scripting environments. # Associated PRs - rmmagent: amidaware/rmmagent#38 - tacticalrmm: amidaware/tacticalrmm#1676 - tacticalrmm-web: amidaware/tacticalrmm-web#14 - trmm-docs: amidaware/trmm-docs#217 - community-scripts: TBD # Questions - macOS uses `/opt/tacticalagent` but Linux does not. Should this be created to hold the `nu` and `deno` binaries? - Added `/opt/tacticalagent` to the Linux agent and uninstall script. - Should the \*nix binaries reside in `/opt/tacticalagent/bin/`? I noticed the Mac agent is in `/opt/tacticalagent/tacticalagent` and stores old versions as `*-v1.2.3`. - Yes. # Out of scope. - macOS: `/opt/tacticalagent` permissions (o-rwx, 0x750) do not permit reading by the user. When Run As User is implemented for Mac/Linux, this will need to be changed. - A fresh install has the correct permissions. This should not be an issue. # TODO These items are done. - [x] Download and uncompress the files from GitHub - [x] Save them in Tactical's "bin" directory (platform dependent). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>