[PR #15] [CLOSED] Big refactor #52

New issue

Closed

opened 2026-03-02 02:12:59 +03:00 by kerem · 0 comments

kerem commented

2026-03-02 02:12:59 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/amidaware/rmmagent/pull/15
Author: @redanthrax
Created: 6/24/2022
Status: ❌ Closed

Base: develop ← Head: BigRefactor

📝 Commits (10+)

6f159d4 organizing and refactoring
e3d5bf2 readme update
1b9669f moar refactor
9347008 fixed windows build - removed test dep
d5fa217 fixed linux build
d6cd817 Merge remote-tracking branch 'origin/RefactorDebug' into BigRefactor
93db0f1 even moar refactor
6abf716 small changed switching to windows
7fbb0fe big refactor
a2ed11b returned existing files to origin during restruct

📊 Changes

105 files changed (+9088 additions, -372 deletions)

View changed files

📝 .github/workflows/ci.yml (+3 -3)
➕ .github/workflows/tests.yml (+53 -0)
📝 .vscode/settings.json (+6 -1)
📝 README.md (+37 -2)
📝 agent/agent.go (+4 -53)
➕ agent/agent_test.go (+34 -0)
📝 agent/agent_unix.go (+49 -5)
➕ agent/agent_unix_test.go (+68 -0)
📝 agent/agent_windows.go (+3 -3)
➕ agent/agent_windows_test.go (+65 -0)
📝 agent/checkin.go (+1 -0)
📝 agent/checks.go (+9 -15)
➕ agent/choco/choco_unix.go (+12 -0)
➕ agent/choco/choco_windows.go (+66 -0)
➕ agent/choco/choco_windows_test.go (+59 -0)
➕ agent/choco/structs.go (+6 -0)
➕ agent/disk/disk_test.go (+42 -0)
➕ agent/disk/disk_unix.go (+42 -0)
➕ agent/disk/disk_windows.go (+50 -0)
➕ agent/disk/structs.go (+10 -0)

...and 80 more files

📄 Description

proposal for changing/organizing in a more modular way to organize tests and maintain modules for different architectures.
original agent code still builds and refactored code is unused at this time
let me know if this approach works or if it's rejected all together
added tests and tested in windows/linux/macos

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/amidaware/rmmagent/pull/15 **Author:** [@redanthrax](https://github.com/redanthrax) **Created:** 6/24/2022 **Status:** ❌ Closed **Base:** `develop` ← **Head:** `BigRefactor` --- ### 📝 Commits (10+) - [`6f159d4`](https://github.com/amidaware/rmmagent/commit/6f159d47288df7d1c04329bd143a108cdbcca7e7) organizing and refactoring - [`e3d5bf2`](https://github.com/amidaware/rmmagent/commit/e3d5bf27a4c5a3b61c7c84da0e59be13cebb58b0) readme update - [`1b9669f`](https://github.com/amidaware/rmmagent/commit/1b9669f35102fc73a179dc6d226c58b9e866d30e) moar refactor - [`9347008`](https://github.com/amidaware/rmmagent/commit/934700844c4a28c35bb73cb1cdbbab4bc1725387) fixed windows build - removed test dep - [`d5fa217`](https://github.com/amidaware/rmmagent/commit/d5fa217b4dd77540e94e93702cb70459bb11f0c3) fixed linux build - [`d6cd817`](https://github.com/amidaware/rmmagent/commit/d6cd81713389b3fd64737c6300a5149b1db353e1) Merge remote-tracking branch 'origin/RefactorDebug' into BigRefactor - [`93db0f1`](https://github.com/amidaware/rmmagent/commit/93db0f17a154696714427b2b6561ba024ca17d61) even moar refactor - [`6abf716`](https://github.com/amidaware/rmmagent/commit/6abf716844a3490c7104cb516fc5064c0c106b04) small changed switching to windows - [`7fbb0fe`](https://github.com/amidaware/rmmagent/commit/7fbb0fe7e1fb0530f50d8fdf2a5d2af85aead6de) big refactor - [`a2ed11b`](https://github.com/amidaware/rmmagent/commit/a2ed11b2fb187c76ac4840aa433bf440e7704665) returned existing files to origin during restruct ### 📊 Changes **105 files changed** (+9088 additions, -372 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/ci.yml` (+3 -3) ➕ `.github/workflows/tests.yml` (+53 -0) 📝 `.vscode/settings.json` (+6 -1) 📝 `README.md` (+37 -2) 📝 `agent/agent.go` (+4 -53) ➕ `agent/agent_test.go` (+34 -0) 📝 `agent/agent_unix.go` (+49 -5) ➕ `agent/agent_unix_test.go` (+68 -0) 📝 `agent/agent_windows.go` (+3 -3) ➕ `agent/agent_windows_test.go` (+65 -0) 📝 `agent/checkin.go` (+1 -0) 📝 `agent/checks.go` (+9 -15) ➕ `agent/choco/choco_unix.go` (+12 -0) ➕ `agent/choco/choco_windows.go` (+66 -0) ➕ `agent/choco/choco_windows_test.go` (+59 -0) ➕ `agent/choco/structs.go` (+6 -0) ➕ `agent/disk/disk_test.go` (+42 -0) ➕ `agent/disk/disk_unix.go` (+42 -0) ➕ `agent/disk/disk_windows.go` (+50 -0) ➕ `agent/disk/structs.go` (+10 -0) _...and 80 more files_ </details> ### 📄 Description proposal for changing/organizing in a more modular way to organize tests and maintain modules for different architectures. original agent code still builds and refactored code is unused at this time let me know if this approach works or if it's rejected all together added tests and tested in windows/linux/macos --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>