[GH-ISSUE #31] build files missing #23

Closed
opened 2026-03-02 02:12:46 +03:00 by kerem · 1 comment
Owner

Originally created by @ykuksenko on GitHub (Feb 12, 2023).
Original GitHub issue: https://github.com/amidaware/rmmagent/issues/31

The setup.iss file references files that seem to be outside the repo. Should these be added to the repo?
github.com/amidaware/rmmagent@396d7db835/build/setup.iss (L22-L23)

The build instructions in the /README.md and /.github/workflows/ci.yml do not use the /build/setup.iss file as far as I can tell. This is likely why this was not apparent.

Originally created by @ykuksenko on GitHub (Feb 12, 2023). Original GitHub issue: https://github.com/amidaware/rmmagent/issues/31 The `setup.iss` file references files that seem to be outside the repo. Should these be added to the repo? https://github.com/amidaware/rmmagent/blob/396d7db8353b572d09ed0bde12faa4e04d284ab2/build/setup.iss#L22-L23 The build instructions in the `/README.md` and `/.github/workflows/ci.yml` do not use the `/build/setup.iss` file as far as I can tell. This is likely why this was not apparent.
kerem closed this issue 2026-03-02 02:12:46 +03:00
Author
Owner

@wh1te909 commented on GitHub (Mar 16, 2023):

these are our company icons and our copyright only. whitelableing feature is being worked on and will be released soon and you'll be able to upload your own icons to compile the agent with.

<!-- gh-comment-id:1472561562 --> @wh1te909 commented on GitHub (Mar 16, 2023): these are our company icons and our copyright only. whitelableing feature is being worked on and will be released soon and you'll be able to upload your own icons to compile the agent with.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/rmmagent#23
No description provided.