[GH-ISSUE #168] repo-remover status? #7

Closed
opened 2026-02-26 04:36:29 +03:00 by kerem · 6 comments
Owner

Originally created by @janosh on GitHub (Oct 6, 2020).
Original GitHub issue: https://github.com/moollaza/repo-remover/issues/168

Originally assigned to: @moollaza on GitHub.

I'm getting an infinite spinner on the latest Chrome (85) and macOS (10.15.7). Disabled all Chrome extensions just in case. Problem remains.

spinner

Originally created by @janosh on GitHub (Oct 6, 2020). Original GitHub issue: https://github.com/moollaza/repo-remover/issues/168 Originally assigned to: @moollaza on GitHub. I'm getting an infinite spinner on the latest Chrome (85) and macOS (10.15.7). Disabled all Chrome extensions just in case. Problem remains. ![spinner](https://user-images.githubusercontent.com/30958850/95188967-85d5bf00-07cd-11eb-9a9f-994b9c1e6275.png)
kerem 2026-02-26 04:36:29 +03:00
  • closed this issue
  • added the
    bug
    label
Author
Owner

@cleor41 commented on GitHub (Oct 7, 2020):

Same

<!-- gh-comment-id:704685834 --> @cleor41 commented on GitHub (Oct 7, 2020): Same
Author
Owner

@moollaza commented on GitHub (Oct 7, 2020):

I just tested and it seems to be working currently.

Edit: I see this now in Chrome and Safari, however Firefox seems to be working fine.

I haven't pushed and changes in a while so I suspect it might be an upstream issues. I'll have to investigate further.

<!-- gh-comment-id:705021935 --> @moollaza commented on GitHub (Oct 7, 2020): ~I just tested and it seems to be working currently.~ Edit: I see this now in Chrome and Safari, however Firefox seems to be working fine. I haven't pushed and changes in a while so I suspect it might be an upstream issues. I'll have to investigate further.
Author
Owner

@janosh commented on GitHub (Oct 7, 2020):

Just retested. Still not working for me. Nothing logged to console.

<!-- gh-comment-id:705024706 --> @janosh commented on GitHub (Oct 7, 2020): Just retested. Still not working for me. Nothing logged to console.
Author
Owner

@moollaza commented on GitHub (Oct 7, 2020):

Thanks for confirming @janosh

I've confirmed the breakage occurred in this PR: https://github.com/moollaza/repo-remover/pull/156

It should be working in the previous build here though: https://repo-remover-git-dependabot-npmandyarndot-prop-421.moollaza.vercel.app/

I'll have to debug what changed in the VueJS update that caused this breakage.

<!-- gh-comment-id:705035261 --> @moollaza commented on GitHub (Oct 7, 2020): Thanks for confirming @janosh I've confirmed the breakage occurred in this PR: https://github.com/moollaza/repo-remover/pull/156 It should be working in the previous build here though: https://repo-remover-git-dependabot-npmandyarndot-prop-421.moollaza.vercel.app/ I'll have to debug what changed in the VueJS update that caused this breakage.
Author
Owner

@moollaza commented on GitHub (Oct 7, 2020):

This should be fixed. I've reverted the PR that caused the issue.

I dug into this for a while, but can't determine what's actually causing the issue.

It appears that for some reason the result() callback is not called in Chrome/Safari when the GraphQl API response is returned, so the loading state is never disabled.

<!-- gh-comment-id:705096480 --> @moollaza commented on GitHub (Oct 7, 2020): This should be fixed. I've reverted the PR that caused the issue. I dug into this for a while, but can't determine what's actually causing the issue. It appears that for some reason the `result()` callback is not called in Chrome/Safari when the GraphQl API response is returned, so the loading state is never disabled.
Author
Owner

@janosh commented on GitHub (Oct 7, 2020):

Confirmed working again. Thanks a lot!

<!-- gh-comment-id:705168098 --> @janosh commented on GitHub (Oct 7, 2020): Confirmed working again. Thanks a lot!
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/repo-remover-moollaza#7
No description provided.