[PR #10] [MERGED] fix(core): resolve test failures and linting issues #86

New issue

Closed

opened 2026-02-27 10:22:10 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 10:22:10 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/mikeyobrien/ralph-orchestrator/pull/10
Author: @mikeyobrien
Created: 12/31/2025
Status: ✅ Merged
Merged: 12/31/2025
Merged by: @mikeyobrien

Base: main ← Head: fix/review-cleanup-and-test-fixes

📝 Commits (1)

62f1483 fix(core): resolve test failures and linting issues

📊 Changes

33 files changed (+59 additions, -117 deletions)

View changed files

📝 src/ralph_orchestrator/adapters/acp.py (+2 -2)
📝 src/ralph_orchestrator/adapters/acp_handlers.py (+0 -1)
📝 src/ralph_orchestrator/context.py (+1 -2)
📝 src/ralph_orchestrator/orchestrator.py (+5 -1)
📝 tests/test_acp_adapter.py (+2 -2)
📝 tests/test_acp_cli.py (+4 -6)
📝 tests/test_acp_client.py (+0 -5)
📝 tests/test_acp_config.py (+0 -2)
📝 tests/test_acp_integration.py (+0 -5)
📝 tests/test_acp_models.py (+0 -1)
📝 tests/test_acp_orchestrator.py (+0 -4)
📝 tests/test_acp_protocol.py (+0 -1)
📝 tests/test_adapters.py (+2 -5)
📝 tests/test_async_logger.py (+1 -2)
📝 tests/test_completion_detection.py (+0 -1)
📝 tests/test_config.py (+0 -2)
📝 tests/test_context.py (+0 -3)
📝 tests/test_integration.py (+1 -4)
📝 tests/test_logging_config.py (+1 -4)
📝 tests/test_metrics.py (+0 -1)

...and 13 more files

📄 Description

Fix broken mocks in test_qchat_message_queue.py
Resolve 100+ ruff linting errors (unused imports, vars)
Fix bare except in test_web_auth.py
Fix import ordering in acp.py
cleanup: remove misleading TODOs in context.py

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/mikeyobrien/ralph-orchestrator/pull/10 **Author:** [@mikeyobrien](https://github.com/mikeyobrien) **Created:** 12/31/2025 **Status:** ✅ Merged **Merged:** 12/31/2025 **Merged by:** [@mikeyobrien](https://github.com/mikeyobrien) **Base:** `main` ← **Head:** `fix/review-cleanup-and-test-fixes` --- ### 📝 Commits (1) - [`62f1483`](https://github.com/mikeyobrien/ralph-orchestrator/commit/62f1483887626ef1f0135fe8a50dcf345ffd1c7f) fix(core): resolve test failures and linting issues ### 📊 Changes **33 files changed** (+59 additions, -117 deletions) <details> <summary>View changed files</summary> 📝 `src/ralph_orchestrator/adapters/acp.py` (+2 -2) 📝 `src/ralph_orchestrator/adapters/acp_handlers.py` (+0 -1) 📝 `src/ralph_orchestrator/context.py` (+1 -2) 📝 `src/ralph_orchestrator/orchestrator.py` (+5 -1) 📝 `tests/test_acp_adapter.py` (+2 -2) 📝 `tests/test_acp_cli.py` (+4 -6) 📝 `tests/test_acp_client.py` (+0 -5) 📝 `tests/test_acp_config.py` (+0 -2) 📝 `tests/test_acp_integration.py` (+0 -5) 📝 `tests/test_acp_models.py` (+0 -1) 📝 `tests/test_acp_orchestrator.py` (+0 -4) 📝 `tests/test_acp_protocol.py` (+0 -1) 📝 `tests/test_adapters.py` (+2 -5) 📝 `tests/test_async_logger.py` (+1 -2) 📝 `tests/test_completion_detection.py` (+0 -1) 📝 `tests/test_config.py` (+0 -2) 📝 `tests/test_context.py` (+0 -3) 📝 `tests/test_integration.py` (+1 -4) 📝 `tests/test_logging_config.py` (+1 -4) 📝 `tests/test_metrics.py` (+0 -1) _...and 13 more files_ </details> ### 📄 Description - Fix broken mocks in test_qchat_message_queue.py - Resolve 100+ ruff linting errors (unused imports, vars) - Fix bare except in test_web_auth.py - Fix import ordering in acp.py - cleanup: remove misleading TODOs in context.py --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>