[PR #205] [MERGED] refactor(core,api,e2e,tui): replace deprecated Duration methods and improve config presets #198

New issue

Closed

opened 2026-02-27 10:22:41 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 10:22:41 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/mikeyobrien/ralph-orchestrator/pull/205
Author: @mikeyobrien
Created: 2/26/2026
Status: ✅ Merged
Merged: 2/26/2026
Merged by: @mikeyobrien

Base: main ← Head: improve-config

📝 Commits (1)

d55f1f3 refactor(core,api,e2e,tui): replace deprecated Duration methods with from_secs

📊 Changes

12 files changed (+634 additions, -138 deletions)

View changed files

📝 crates/ralph-api/src/idempotency.rs (+2 -2)
📝 crates/ralph-core/src/event_loop/tests.rs (+1 -1)
📝 crates/ralph-core/src/testing/smoke_runner.rs (+2 -2)
📝 crates/ralph-core/src/utils.rs (+1 -1)
📝 crates/ralph-core/tests/smoke_runner.rs (+2 -2)
📝 crates/ralph-e2e/src/analyzer.rs (+5 -5)
📝 crates/ralph-e2e/src/backend.rs (+2 -2)
📝 crates/ralph-e2e/src/executor.rs (+2 -2)
📝 crates/ralph-e2e/src/scenarios/incremental.rs (+3 -3)
📝 crates/ralph-tui/src/widgets/header.rs (+2 -2)
➕ ralph.qa.yml (+407 -0)
📝 ralph.yml (+205 -116)

📄 Description

Summary

Replace deprecated Duration::from_mins() and Duration::from_hours() with Duration::from_secs() across the codebase, and improve the orchestration config presets.

Changes

Duration fixes

Replace Duration::from_mins() with Duration::from_secs() in all crates
Replace Duration::from_hours() with Duration::from_secs() in test assertions
Affected crates: ralph-api, ralph-core, ralph-e2e, ralph-tui

Config improvements (`ralph.yml`)

Switch to planner → builder → reviewer → finalizer hat pipeline
Add backpressure gates (fmt, clippy, test)
Add crate-scoped guardrails and sub-task granularity
Scope sub-tasks to individual crates
Switch default backend to pi

New QA preset (`ralph.qa.yml`)

Superset of ralph.yml adding a QA gate for event loop and TUI changes
QA planner diffs origin/main to scope impacting changes
QA tester executes targets via tmux split panes
Hard stop after 3 QA rounds
Auto-skips QA for non-impacting changes (docs, presets)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/mikeyobrien/ralph-orchestrator/pull/205 **Author:** [@mikeyobrien](https://github.com/mikeyobrien) **Created:** 2/26/2026 **Status:** ✅ Merged **Merged:** 2/26/2026 **Merged by:** [@mikeyobrien](https://github.com/mikeyobrien) **Base:** `main` ← **Head:** `improve-config` --- ### 📝 Commits (1) - [`d55f1f3`](https://github.com/mikeyobrien/ralph-orchestrator/commit/d55f1f35b8de1cc7aac7c2a578f4feb5bd6551d1) refactor(core,api,e2e,tui): replace deprecated Duration methods with from_secs ### 📊 Changes **12 files changed** (+634 additions, -138 deletions) <details> <summary>View changed files</summary> 📝 `crates/ralph-api/src/idempotency.rs` (+2 -2) 📝 `crates/ralph-core/src/event_loop/tests.rs` (+1 -1) 📝 `crates/ralph-core/src/testing/smoke_runner.rs` (+2 -2) 📝 `crates/ralph-core/src/utils.rs` (+1 -1) 📝 `crates/ralph-core/tests/smoke_runner.rs` (+2 -2) 📝 `crates/ralph-e2e/src/analyzer.rs` (+5 -5) 📝 `crates/ralph-e2e/src/backend.rs` (+2 -2) 📝 `crates/ralph-e2e/src/executor.rs` (+2 -2) 📝 `crates/ralph-e2e/src/scenarios/incremental.rs` (+3 -3) 📝 `crates/ralph-tui/src/widgets/header.rs` (+2 -2) ➕ `ralph.qa.yml` (+407 -0) 📝 `ralph.yml` (+205 -116) </details> ### 📄 Description ## Summary Replace deprecated `Duration::from_mins()` and `Duration::from_hours()` with `Duration::from_secs()` across the codebase, and improve the orchestration config presets. ## Changes ### Duration fixes - Replace `Duration::from_mins()` with `Duration::from_secs()` in all crates - Replace `Duration::from_hours()` with `Duration::from_secs()` in test assertions - Affected crates: `ralph-api`, `ralph-core`, `ralph-e2e`, `ralph-tui` ### Config improvements (`ralph.yml`) - Switch to planner → builder → reviewer → finalizer hat pipeline - Add backpressure gates (fmt, clippy, test) - Add crate-scoped guardrails and sub-task granularity - Scope sub-tasks to individual crates - Switch default backend to `pi` ### New QA preset (`ralph.qa.yml`) - Superset of ralph.yml adding a QA gate for event loop and TUI changes - QA planner diffs origin/main to scope impacting changes - QA tester executes targets via tmux split panes - Hard stop after 3 QA rounds - Auto-skips QA for non-impacting changes (docs, presets) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>