[PR #201] [MERGED] fix: resolve clippy warnings and add missing ACP struct fields #196

New issue

Closed

opened 2026-02-27 10:22:40 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 10:22:40 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/mikeyobrien/ralph-orchestrator/pull/201
Author: @jsamuel1
Created: 2/26/2026
Status: ✅ Merged
Merged: 2/26/2026
Merged by: @mikeyobrien

Base: main ← Head: fix/clippy-and-missing-fields

📝 Commits (1)

caa4630 fix: resolve clippy warnings and add missing struct fields

📊 Changes

11 files changed (+34 additions, -20 deletions)

View changed files

📝 crates/ralph-adapters/src/acp_executor.rs (+9 -0)
📝 crates/ralph-api/src/idempotency.rs (+2 -2)
📝 crates/ralph-cli/src/loop_runner.rs (+5 -0)
📝 crates/ralph-core/src/event_loop/tests.rs (+1 -1)
📝 crates/ralph-core/src/testing/smoke_runner.rs (+2 -2)
📝 crates/ralph-core/src/utils.rs (+1 -1)
📝 crates/ralph-e2e/src/analyzer.rs (+5 -5)
📝 crates/ralph-e2e/src/backend.rs (+2 -2)
📝 crates/ralph-e2e/src/executor.rs (+2 -2)
📝 crates/ralph-e2e/src/scenarios/incremental.rs (+3 -3)
📝 crates/ralph-tui/src/widgets/header.rs (+2 -2)

📄 Description

Fix duration_suboptimal_units clippy warnings across all crates (from_secs → from_mins/from_hours)
Add missing token/cost fields to ACP executor structs (SessionResult, PtyExecutionResult, ExecutionOutcome) added upstream in #200
All 402 tests pass, zero clippy warnings, formatting clean

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/mikeyobrien/ralph-orchestrator/pull/201 **Author:** [@jsamuel1](https://github.com/jsamuel1) **Created:** 2/26/2026 **Status:** ✅ Merged **Merged:** 2/26/2026 **Merged by:** [@mikeyobrien](https://github.com/mikeyobrien) **Base:** `main` ← **Head:** `fix/clippy-and-missing-fields` --- ### 📝 Commits (1) - [`caa4630`](https://github.com/mikeyobrien/ralph-orchestrator/commit/caa4630d9be421a105c6821db4a63615900b2603) fix: resolve clippy warnings and add missing struct fields ### 📊 Changes **11 files changed** (+34 additions, -20 deletions) <details> <summary>View changed files</summary> 📝 `crates/ralph-adapters/src/acp_executor.rs` (+9 -0) 📝 `crates/ralph-api/src/idempotency.rs` (+2 -2) 📝 `crates/ralph-cli/src/loop_runner.rs` (+5 -0) 📝 `crates/ralph-core/src/event_loop/tests.rs` (+1 -1) 📝 `crates/ralph-core/src/testing/smoke_runner.rs` (+2 -2) 📝 `crates/ralph-core/src/utils.rs` (+1 -1) 📝 `crates/ralph-e2e/src/analyzer.rs` (+5 -5) 📝 `crates/ralph-e2e/src/backend.rs` (+2 -2) 📝 `crates/ralph-e2e/src/executor.rs` (+2 -2) 📝 `crates/ralph-e2e/src/scenarios/incremental.rs` (+3 -3) 📝 `crates/ralph-tui/src/widgets/header.rs` (+2 -2) </details> ### 📄 Description - Fix `duration_suboptimal_units` clippy warnings across all crates (from_secs → from_mins/from_hours) - Add missing token/cost fields to ACP executor structs (SessionResult, PtyExecutionResult, ExecutionOutcome) added upstream in #200 - All 402 tests pass, zero clippy warnings, formatting clean --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>