[PR #141] [MERGED] feat: completion only via event #160

New issue

Closed

opened 2026-02-27 10:22:28 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 10:22:28 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/mikeyobrien/ralph-orchestrator/pull/141
Author: @mikeyobrien
Created: 1/31/2026
Status: ✅ Merged
Merged: 1/31/2026
Merged by: @mikeyobrien

Base: main ← Head: feat/completion-event-only

📝 Commits (2)

3340040 feat: add graceful /stop command and signal-based loop termination
50f6ad0 feat: complete only via event

📊 Changes

28 files changed (+745 additions, -203 deletions)

View changed files

📝 .gitignore (+3 -0)
📝 crates/ralph-cli/src/bot.rs (+268 -28)
📝 crates/ralph-cli/src/loop_runner.rs (+60 -0)
📝 crates/ralph-cli/src/loops.rs (+47 -67)
📝 crates/ralph-core/data/robot-interaction-skill.md (+3 -0)
📝 crates/ralph-core/src/config.rs (+25 -1)
📝 crates/ralph-core/src/diagnostics/integration_tests.rs (+12 -3)
📝 crates/ralph-core/src/event_loop/loop_state.rs (+3 -0)
📝 crates/ralph-core/src/event_loop/mod.rs (+70 -37)
📝 crates/ralph-core/src/event_loop/tests.rs (+69 -24)
📝 crates/ralph-core/src/event_parser.rs (+33 -4)
📝 crates/ralph-core/src/hatless_ralph.rs (+7 -6)
📝 crates/ralph-core/src/summary_writer.rs (+1 -0)
📝 crates/ralph-core/src/testing/smoke_runner.rs (+7 -4)
📝 crates/ralph-core/tests/event_loop_ralph.rs (+6 -6)
📝 crates/ralph-core/tests/fixtures/README.md (+1 -1)
📝 crates/ralph-core/tests/fixtures/basic_session.jsonl (+1 -1)
📝 crates/ralph-core/tests/fixtures/claude_complex_session.jsonl (+1 -1)
📝 crates/ralph-core/tests/fixtures/kiro/README.md (+1 -1)
📝 crates/ralph-core/tests/fixtures/kiro/basic_kiro_session.jsonl (+3 -3)

...and 8 more files

📄 Description

Summary

require completion via emitted event only (no stdout sentinel)
track completion_requested in loop state and check after event processing
update prompt guidance to instruct ralph emit completion events
update tests, fixtures, smoke runner, and diagnostics to use completion events
completion parsing only honors event tags

Testing

cargo test

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/mikeyobrien/ralph-orchestrator/pull/141 **Author:** [@mikeyobrien](https://github.com/mikeyobrien) **Created:** 1/31/2026 **Status:** ✅ Merged **Merged:** 1/31/2026 **Merged by:** [@mikeyobrien](https://github.com/mikeyobrien) **Base:** `main` ← **Head:** `feat/completion-event-only` --- ### 📝 Commits (2) - [`3340040`](https://github.com/mikeyobrien/ralph-orchestrator/commit/3340040f802e9706fe2c5fbd8651bf2f82febce0) feat: add graceful /stop command and signal-based loop termination - [`50f6ad0`](https://github.com/mikeyobrien/ralph-orchestrator/commit/50f6ad0a970a5462974d5e739e91452b192440f7) feat: complete only via event ### 📊 Changes **28 files changed** (+745 additions, -203 deletions) <details> <summary>View changed files</summary> 📝 `.gitignore` (+3 -0) 📝 `crates/ralph-cli/src/bot.rs` (+268 -28) 📝 `crates/ralph-cli/src/loop_runner.rs` (+60 -0) 📝 `crates/ralph-cli/src/loops.rs` (+47 -67) 📝 `crates/ralph-core/data/robot-interaction-skill.md` (+3 -0) 📝 `crates/ralph-core/src/config.rs` (+25 -1) 📝 `crates/ralph-core/src/diagnostics/integration_tests.rs` (+12 -3) 📝 `crates/ralph-core/src/event_loop/loop_state.rs` (+3 -0) 📝 `crates/ralph-core/src/event_loop/mod.rs` (+70 -37) 📝 `crates/ralph-core/src/event_loop/tests.rs` (+69 -24) 📝 `crates/ralph-core/src/event_parser.rs` (+33 -4) 📝 `crates/ralph-core/src/hatless_ralph.rs` (+7 -6) 📝 `crates/ralph-core/src/summary_writer.rs` (+1 -0) 📝 `crates/ralph-core/src/testing/smoke_runner.rs` (+7 -4) 📝 `crates/ralph-core/tests/event_loop_ralph.rs` (+6 -6) 📝 `crates/ralph-core/tests/fixtures/README.md` (+1 -1) 📝 `crates/ralph-core/tests/fixtures/basic_session.jsonl` (+1 -1) 📝 `crates/ralph-core/tests/fixtures/claude_complex_session.jsonl` (+1 -1) 📝 `crates/ralph-core/tests/fixtures/kiro/README.md` (+1 -1) 📝 `crates/ralph-core/tests/fixtures/kiro/basic_kiro_session.jsonl` (+3 -3) _...and 8 more files_ </details> ### 📄 Description ## Summary - require completion via emitted event only (no stdout sentinel) - track completion_requested in loop state and check after event processing - update prompt guidance to instruct `ralph emit` completion events - update tests, fixtures, smoke runner, and diagnostics to use completion events - completion parsing only honors event tags ## Testing - cargo test --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>