[PR #131] [CLOSED] fix: embed memories skill for crate publish & honor CLI command override #153

New issue

Closed

opened 2026-02-27 10:22:26 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 10:22:26 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/mikeyobrien/ralph-orchestrator/pull/131
Author: @mikeyobrien
Created: 1/28/2026
Status: ❌ Closed

Base: main ← Head: fix/include-str-crate-publish

📝 Commits (10+)

cd87614 fix(parallel-loops): Wire LoopRegistry.register() into worktree spawn flow
98f09e4 feat(loops): add --json flag to ralph loops list
74a07dc refactor: relocate specs and tasks to .ralph/ directory
9eae366 feat(web): add web dashboard (backend + frontend)
d10b599 docs: update CLAUDE.md with web dashboard and architecture
eb1f7e0 fix(events): use atomic write for JSONL event logging
413dae5 fix(loop): clear scratchpad on fresh runs to prevent stale state
ad8fd85 feat(core): add parallel loop infrastructure
b5ef7f4 feat(cli): implement parallel loop orchestration
b41640f feat(web): add backend API for loop management

📊 Changes

421 files changed (+35081 additions, -1501 deletions)

View changed files

➖ .agent/memories.md (+0 -69)
➖ .agent/tasks.jsonl (+0 -29)
📝 .claude/skills/code-task-generator/SKILL.md (+3 -3)
📝 .claude/skills/find-code-tasks/SKILL.md (+13 -13)
➕ .claude/skills/ralph-loop/SKILL.md (+300 -0)
📝 .gitignore (+27 -4)
📝 .ralph/specs/README.md (+0 -0)
📝 .ralph/specs/adapters/amp.spec.md (+0 -0)
📝 .ralph/specs/adapters/claude/design/detailed-design.md (+0 -0)
📝 .ralph/specs/adapters/claude/idea-honing.md (+0 -0)
📝 .ralph/specs/adapters/claude/implementation/plan.md (+0 -0)
📝 .ralph/specs/adapters/claude/research/adapter-streaming-analysis.md (+0 -0)
📝 .ralph/specs/adapters/claude/research/deprecated-spec.md (+0 -0)
📝 .ralph/specs/adapters/claude/research/implementation-gap-analysis.md (+0 -0)
📝 .ralph/specs/adapters/claude/rough-idea.md (+0 -0)
📝 .ralph/specs/adapters/claude/summary.md (+0 -0)
📝 .ralph/specs/adapters/codex.spec.md (+0 -0)
📝 .ralph/specs/adapters/gemini.spec.md (+0 -0)
📝 .ralph/specs/adapters/kiro.spec.md (+0 -0)
📝 .ralph/specs/beads-lite.spec.md (+0 -0)

...and 80 more files

📄 Description

Summary

Moves the memories skill markdown from .claude/skills/ralph-memories/SKILL.md into crates/ralph-core/data/memories-skill.md so it ships with the published crate
Updates include_str! path in event_loop/mod.rs to reference the new in-crate location
Fix backend-unavailable E2E test (release blocker): CliBackend::from_config() now honors config.command as a command override for named backends (claude, kiro, etc.), not just custom. Previously the command field was silently ignored, so the E2E test's command: nonexistent-cli-... had no effect and ralph used the real installed binary.
Adds unit test test_from_config_command_override validating the override behavior

Closes #130

Test plan

cargo build succeeds
cargo test — all tests pass (including new test_from_config_command_override)
cargo package --list confirms data/memories-skill.md is included
cargo run -p ralph-e2e -- --filter backend-unavailable — all 3 backends pass (claude, kiro, opencode)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/mikeyobrien/ralph-orchestrator/pull/131 **Author:** [@mikeyobrien](https://github.com/mikeyobrien) **Created:** 1/28/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fix/include-str-crate-publish` --- ### 📝 Commits (10+) - [`cd87614`](https://github.com/mikeyobrien/ralph-orchestrator/commit/cd8761461c99c5eff75e2857e7179bde7f5b97e9) fix(parallel-loops): Wire LoopRegistry.register() into worktree spawn flow - [`98f09e4`](https://github.com/mikeyobrien/ralph-orchestrator/commit/98f09e4656f1a4696a7aeec3159cc57d6de5d59c) feat(loops): add --json flag to `ralph loops list` - [`74a07dc`](https://github.com/mikeyobrien/ralph-orchestrator/commit/74a07dcccca31a361d42af8910d1d1913e5bf9fe) refactor: relocate specs and tasks to .ralph/ directory - [`9eae366`](https://github.com/mikeyobrien/ralph-orchestrator/commit/9eae36680ac94be06568db783599886555b3778f) feat(web): add web dashboard (backend + frontend) - [`d10b599`](https://github.com/mikeyobrien/ralph-orchestrator/commit/d10b5998070f30af425b9464ce6ccb67728e2d6c) docs: update CLAUDE.md with web dashboard and architecture - [`eb1f7e0`](https://github.com/mikeyobrien/ralph-orchestrator/commit/eb1f7e0e4ea585bbefd895b70c2a0959bcc0c02d) fix(events): use atomic write for JSONL event logging - [`413dae5`](https://github.com/mikeyobrien/ralph-orchestrator/commit/413dae5675a91fa7b3cdf5479accc9f747480c75) fix(loop): clear scratchpad on fresh runs to prevent stale state - [`ad8fd85`](https://github.com/mikeyobrien/ralph-orchestrator/commit/ad8fd85601db64ce3cee2a9cc0999c8c0ff57669) feat(core): add parallel loop infrastructure - [`b5ef7f4`](https://github.com/mikeyobrien/ralph-orchestrator/commit/b5ef7f49e6ee63a785d00b1b0fa28893869c6c67) feat(cli): implement parallel loop orchestration - [`b41640f`](https://github.com/mikeyobrien/ralph-orchestrator/commit/b41640f0244d662b7d5342289b93390c63341bfb) feat(web): add backend API for loop management ### 📊 Changes **421 files changed** (+35081 additions, -1501 deletions) <details> <summary>View changed files</summary> ➖ `.agent/memories.md` (+0 -69) ➖ `.agent/tasks.jsonl` (+0 -29) 📝 `.claude/skills/code-task-generator/SKILL.md` (+3 -3) 📝 `.claude/skills/find-code-tasks/SKILL.md` (+13 -13) ➕ `.claude/skills/ralph-loop/SKILL.md` (+300 -0) 📝 `.gitignore` (+27 -4) 📝 `.ralph/specs/README.md` (+0 -0) 📝 `.ralph/specs/adapters/amp.spec.md` (+0 -0) 📝 `.ralph/specs/adapters/claude/design/detailed-design.md` (+0 -0) 📝 `.ralph/specs/adapters/claude/idea-honing.md` (+0 -0) 📝 `.ralph/specs/adapters/claude/implementation/plan.md` (+0 -0) 📝 `.ralph/specs/adapters/claude/research/adapter-streaming-analysis.md` (+0 -0) 📝 `.ralph/specs/adapters/claude/research/deprecated-spec.md` (+0 -0) 📝 `.ralph/specs/adapters/claude/research/implementation-gap-analysis.md` (+0 -0) 📝 `.ralph/specs/adapters/claude/rough-idea.md` (+0 -0) 📝 `.ralph/specs/adapters/claude/summary.md` (+0 -0) 📝 `.ralph/specs/adapters/codex.spec.md` (+0 -0) 📝 `.ralph/specs/adapters/gemini.spec.md` (+0 -0) 📝 `.ralph/specs/adapters/kiro.spec.md` (+0 -0) 📝 `.ralph/specs/beads-lite.spec.md` (+0 -0) _...and 80 more files_ </details> ### 📄 Description ## Summary - Moves the memories skill markdown from `.claude/skills/ralph-memories/SKILL.md` into `crates/ralph-core/data/memories-skill.md` so it ships with the published crate - Updates `include_str!` path in `event_loop/mod.rs` to reference the new in-crate location - **Fix `backend-unavailable` E2E test (release blocker):** `CliBackend::from_config()` now honors `config.command` as a command override for named backends (claude, kiro, etc.), not just `custom`. Previously the command field was silently ignored, so the E2E test's `command: nonexistent-cli-...` had no effect and ralph used the real installed binary. - Adds unit test `test_from_config_command_override` validating the override behavior Closes #130 ## Test plan - [x] `cargo build` succeeds - [x] `cargo test` — all tests pass (including new `test_from_config_command_override`) - [x] `cargo package --list` confirms `data/memories-skill.md` is included - [x] `cargo run -p ralph-e2e -- --filter backend-unavailable` — all 3 backends pass (claude, kiro, opencode) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>