[PR #10] [MERGED] Added Minor Fixes and Dynamic Wait Time for AT Command Page #74

Closed
opened 2026-02-27 14:38:59 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/iamromulan/quectel-rgmii-toolkit/pull/10
Author: @dr-dolomite
Created: 3/17/2024
Status: Merged
Merged: 3/17/2024
Merged by: @iamromulan

Base: developmentHead: main


📝 Commits (10+)

  • 9a385f3 Merge iamromulan/quectel-rgmii-toolkit/development into iamromulan/quectel-rgmii-toolkit/main (20240223)
  • b6139c8 Single Command: Download and run the toolkit
  • d218166 Fix branch name in link
  • dd0f74a Update Tree to main
  • d8ed2fd Fix Wget links
  • 0179c92 Add a delay to give /opt time to mount
  • 7bf87e4 add opkg update process
  • 0b25cbe Fixed unknown NR5G band
  • 42ef308 Update README.md
  • a08f65d Add LICENSE

📊 Changes

9 files changed (+473 additions, -184 deletions)

View changed files

📝 README.md (+2 -1)
📝 simpleadmin/scripts/build_modem_status (+3 -3)
📝 simpleadmin/scripts/modemstatus_parse.sh (+2 -5)
📝 simpleadmin/scripts/tojson.sh (+7 -0)
📝 simpleadmin/www/atcommander.html (+273 -149)
📝 simpleadmin/www/cgi-bin/get_atcommand (+20 -14)
📝 simpleadmin/www/index.html (+3 -2)
simpleadmin/www/sms.html (+158 -0)
📝 simpleadmin/www/ttl.html (+5 -10)

📄 Description

This PR includes these changes:

  • Fixed APN not showing when a profile was set.
  • Fixed Navbar titles showing "RM5xxx" and changed it to Simple Admin
  • Removed all "Quectel" names to use a generic branding.
  • Added SMS on Navbar
  • Added SMS for testing

This commit added clear button and disabled states includes:

  • Added clear button to at command page
  • Added disabled states
  • Added "Fetching response, please wait..." state when waiting for response
  • Changed placeholder to "Please send only 1 AT command at a time"

These changes on atcommander.html is production ready. Other changes can also be merged. Only SMS is for testing.

I tried to add the dynamic loading time to get_atcommand based on atcmd logic. The quick response commands are now lightning fast! AT+QSCAN also works. Check the changes here in this commit:
incorporated atcmd dynamic wait time to get_atcommand


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/iamromulan/quectel-rgmii-toolkit/pull/10 **Author:** [@dr-dolomite](https://github.com/dr-dolomite) **Created:** 3/17/2024 **Status:** ✅ Merged **Merged:** 3/17/2024 **Merged by:** [@iamromulan](https://github.com/iamromulan) **Base:** `development` ← **Head:** `main` --- ### 📝 Commits (10+) - [`9a385f3`](https://github.com/iamromulan/quectel-rgmii-toolkit/commit/9a385f32f6229e1244b2ff075bb7454cc67c7bd9) Merge iamromulan/quectel-rgmii-toolkit/development into iamromulan/quectel-rgmii-toolkit/main (20240223) - [`b6139c8`](https://github.com/iamromulan/quectel-rgmii-toolkit/commit/b6139c8ed3aae9730b4799eb94a66201321532c0) Single Command: Download and run the toolkit - [`d218166`](https://github.com/iamromulan/quectel-rgmii-toolkit/commit/d21816632971ddb28fd3df2f972b884d02319076) Fix branch name in link - [`dd0f74a`](https://github.com/iamromulan/quectel-rgmii-toolkit/commit/dd0f74ae39b0122e6aad2e5a90c6ac256264cbab) Update Tree to main - [`d8ed2fd`](https://github.com/iamromulan/quectel-rgmii-toolkit/commit/d8ed2fd48fbcea3bc46d41caf94bd3d3973ce6fa) Fix Wget links - [`0179c92`](https://github.com/iamromulan/quectel-rgmii-toolkit/commit/0179c92213abd22bfe166a062c6a6a85d3d305d7) Add a delay to give /opt time to mount - [`7bf87e4`](https://github.com/iamromulan/quectel-rgmii-toolkit/commit/7bf87e4f3bb5bd47e6a5ce944059474606c08c9c) add opkg update process - [`0b25cbe`](https://github.com/iamromulan/quectel-rgmii-toolkit/commit/0b25cbefd8ceb3c9e676a2ff72d03d2926e7829b) Fixed unknown NR5G band - [`42ef308`](https://github.com/iamromulan/quectel-rgmii-toolkit/commit/42ef30877f8f291eea5ba2440aea250d15c10405) Update README.md - [`a08f65d`](https://github.com/iamromulan/quectel-rgmii-toolkit/commit/a08f65d02dab5e44ded503dedc90fec3c2d30218) Add LICENSE ### 📊 Changes **9 files changed** (+473 additions, -184 deletions) <details> <summary>View changed files</summary> 📝 `README.md` (+2 -1) 📝 `simpleadmin/scripts/build_modem_status` (+3 -3) 📝 `simpleadmin/scripts/modemstatus_parse.sh` (+2 -5) 📝 `simpleadmin/scripts/tojson.sh` (+7 -0) 📝 `simpleadmin/www/atcommander.html` (+273 -149) 📝 `simpleadmin/www/cgi-bin/get_atcommand` (+20 -14) 📝 `simpleadmin/www/index.html` (+3 -2) ➕ `simpleadmin/www/sms.html` (+158 -0) 📝 `simpleadmin/www/ttl.html` (+5 -10) </details> ### 📄 Description This PR includes these changes: - Fixed APN not showing when a profile was set. - Fixed Navbar titles showing "RM5xxx" and changed it to Simple Admin - Removed all "Quectel" names to use a generic branding. - Added SMS on Navbar - Added SMS for testing This commit [added clear button and disabled states](https://github.com/iamromulan/quectel-rgmii-toolkit/pull/10/commits/b450fd281366a8d9884115fb68d2a3f376c929c1) includes: - Added clear button to at command page - Added disabled states - Added "Fetching response, please wait..." state when waiting for response - Changed placeholder to "Please send only 1 AT command at a time" These changes on atcommander.html is production ready. Other changes can also be merged. Only SMS is for testing. I tried to add the dynamic loading time to get_atcommand based on atcmd logic. The quick response commands are now lightning fast! AT+QSCAN also works. Check the changes here in this commit: [incorporated atcmd dynamic wait time to get_atcommand](https://github.com/iamromulan/quectel-rgmii-toolkit/pull/10/commits/80b34719a5fad4d0d9c7ae27a7040c87bc7429dd) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-27 14:38:59 +03:00
Sign in to join this conversation.
No labels
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/quectel-rgmii-toolkit#74
No description provided.