[PR #15] [MERGED] Add reserved key checks for custom bindings #31

New issue

Closed

opened 2026-02-26 18:43:17 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 18:43:17 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/devnullvoid/pvetui/pull/15
Author: @devnullvoid
Created: 7/3/2025
Status: ✅ Merged
Merged: 7/4/2025
Merged by: @devnullvoid

Base: develop ← Head: codex/add-key-mapping-configuration-to-config-file

📝 Commits (10+)

d92b246 🔧 Fix shell connections and add Windows ARM64 support
b6056e0 Reject system reserved combos
1457f9b Merge branch 'codex/add-key-mapping-configuration-to-config-file' of github.com:devnullvoid/proxmox-tui into codex/add-key-mapping-configuration-to-config-file
c80181f Handle ctrl letter events
6ce75a8 Merge branch 'codex/add-key-mapping-configuration-to-config-file' of github.com:devnullvoid/proxmox-tui into codex/add-key-mapping-configuration-to-config-file
60a2fca Handle shift and multi-modifier key bindings
e694684 Merge branch 'codex/add-key-mapping-configuration-to-config-file' of github.com:devnullvoid/proxmox-tui into codex/add-key-mapping-configuration-to-config-file
36e32f2 Fix Tab detection in key matching
a49ebbf Merge branch 'codex/add-key-mapping-configuration-to-config-file' of github.com:devnullvoid/proxmox-tui into codex/add-key-mapping-configuration-to-config-file
1e8c177 Add debug logging for key events

📊 Changes

13 files changed (+906 additions, -297 deletions)

View changed files

📝 CHANGELOG.md (+10 -11)
📝 README.md (+63 -14)
📝 configs/config.tpl.yml (+20 -2)
📝 internal/config/config.go (+229 -11)
📝 internal/config/config_test.go (+26 -0)
➕ internal/keys/parse.go (+231 -0)
➕ internal/keys/parse_test.go (+64 -0)
📝 internal/ssh/client.go (+4 -45)
📝 internal/ui/components/app.go (+2 -1)
📝 internal/ui/components/footer.go (+17 -1)
📝 internal/ui/components/help_modal.go (+91 -89)
📝 internal/ui/components/keyboard.go (+140 -90)
📝 internal/ui/components/shell.go (+9 -33)

📄 Description

Summary

reject reserved and duplicate key bindings during validation
document reserved keys in README and sample config
add tests for key binding validation
block system combinations like Ctrl+C

Testing

git submodule update --init --recursive
make build
make lint
go vet ./...
make test

https://chatgpt.com/codex/tasks/task_e_6866306ff54c8328b999a035f40c8ac3

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/devnullvoid/pvetui/pull/15 **Author:** [@devnullvoid](https://github.com/devnullvoid) **Created:** 7/3/2025 **Status:** ✅ Merged **Merged:** 7/4/2025 **Merged by:** [@devnullvoid](https://github.com/devnullvoid) **Base:** `develop` ← **Head:** `codex/add-key-mapping-configuration-to-config-file` --- ### 📝 Commits (10+) - [`d92b246`](https://github.com/devnullvoid/pvetui/commit/d92b246ad1dfb9a00bfe2e0dc057a0716e8933ff) 🔧 Fix shell connections and add Windows ARM64 support - [`b6056e0`](https://github.com/devnullvoid/pvetui/commit/b6056e0ccd798215f8f5555e5e23f422b3eb6882) Reject system reserved combos - [`1457f9b`](https://github.com/devnullvoid/pvetui/commit/1457f9b2b55e2cdcc400b4205fc33b5ffe993e57) Merge branch 'codex/add-key-mapping-configuration-to-config-file' of github.com:devnullvoid/proxmox-tui into codex/add-key-mapping-configuration-to-config-file - [`c80181f`](https://github.com/devnullvoid/pvetui/commit/c80181fc47cd28379ccda98cea3b4758030803c6) Handle ctrl letter events - [`6ce75a8`](https://github.com/devnullvoid/pvetui/commit/6ce75a8cd8c40fe6c498c46b0b73f93c5633cdff) Merge branch 'codex/add-key-mapping-configuration-to-config-file' of github.com:devnullvoid/proxmox-tui into codex/add-key-mapping-configuration-to-config-file - [`60a2fca`](https://github.com/devnullvoid/pvetui/commit/60a2fca47b304ea6a4a989e42b1231ca1f6f5707) Handle shift and multi-modifier key bindings - [`e694684`](https://github.com/devnullvoid/pvetui/commit/e694684c148f17eae7f0cb9d979c541d4d933cd7) Merge branch 'codex/add-key-mapping-configuration-to-config-file' of github.com:devnullvoid/proxmox-tui into codex/add-key-mapping-configuration-to-config-file - [`36e32f2`](https://github.com/devnullvoid/pvetui/commit/36e32f2de985be27ce74d77c50a41961139e98ca) Fix Tab detection in key matching - [`a49ebbf`](https://github.com/devnullvoid/pvetui/commit/a49ebbf53dfe97af2ac4642a3bbc8a7693b49059) Merge branch 'codex/add-key-mapping-configuration-to-config-file' of github.com:devnullvoid/proxmox-tui into codex/add-key-mapping-configuration-to-config-file - [`1e8c177`](https://github.com/devnullvoid/pvetui/commit/1e8c1773c622b81919e2b7142baa779a311324ce) Add debug logging for key events ### 📊 Changes **13 files changed** (+906 additions, -297 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELOG.md` (+10 -11) 📝 `README.md` (+63 -14) 📝 `configs/config.tpl.yml` (+20 -2) 📝 `internal/config/config.go` (+229 -11) 📝 `internal/config/config_test.go` (+26 -0) ➕ `internal/keys/parse.go` (+231 -0) ➕ `internal/keys/parse_test.go` (+64 -0) 📝 `internal/ssh/client.go` (+4 -45) 📝 `internal/ui/components/app.go` (+2 -1) 📝 `internal/ui/components/footer.go` (+17 -1) 📝 `internal/ui/components/help_modal.go` (+91 -89) 📝 `internal/ui/components/keyboard.go` (+140 -90) 📝 `internal/ui/components/shell.go` (+9 -33) </details> ### 📄 Description ## Summary - reject reserved and duplicate key bindings during validation - document reserved keys in README and sample config - add tests for key binding validation - block system combinations like Ctrl+C ## Testing - `git submodule update --init --recursive` - `make build` - `make lint` - `go vet ./...` - `make test` ------ https://chatgpt.com/codex/tasks/task_e_6866306ff54c8328b999a035f40c8ac3 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>