[PR #13] [MERGED] Add file cache unit tests #29

New issue

Closed

opened 2026-02-26 18:43:17 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 18:43:17 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/devnullvoid/pvetui/pull/13
Author: @devnullvoid
Created: 7/1/2025
Status: ✅ Merged
Merged: 7/2/2025
Merged by: @devnullvoid

Base: develop ← Head: codex/review-and-refactor-codebase-for-modularity

📝 Commits (5)

b066acd refactor: add UI component interfaces and context
f85cf41 fix: update UI interfaces
c51cf74 fix: align UI component interfaces with tview
de076c1 fix: compile errors after interface refactor
223f856 Merge branch 'develop' into codex/review-and-refactor-codebase-for-modularity

📊 Changes

22 files changed (+795 additions, -604 deletions)

View changed files

📝 CHANGELOG.md (+4 -0)
📝 cmd/proxmox-tui/main.go (+10 -179)
➕ internal/app/run.go (+71 -0)
➕ internal/cache/cache_test.go (+89 -0)
📝 internal/commands/commands.go (+37 -7)
📝 internal/ssh/client.go (+16 -3)
📝 internal/ui/app_runner.go (+3 -2)
📝 internal/ui/components/app.go (+20 -382)
➕ internal/ui/components/auto_refresh.go (+308 -0)
📝 internal/ui/components/cluster_status.go (+2 -0)
📝 internal/ui/components/footer.go (+13 -0)
📝 internal/ui/components/header.go (+7 -0)
➕ internal/ui/components/interfaces.go (+80 -0)
📝 internal/ui/components/node_details.go (+7 -0)
📝 internal/ui/components/node_list.go (+8 -0)
📝 internal/ui/components/refresh.go (+2 -29)
📝 internal/ui/components/search.go (+2 -2)
➕ internal/ui/components/selection.go (+30 -0)
📝 internal/ui/components/tasks_list.go (+7 -0)
📝 internal/ui/components/vm_details.go (+7 -0)

...and 2 more files

📄 Description

Summary

add cache_test.go covering FileCache operations
refactor UI App into smaller files and introduced new thin main
implement TODOs in SSH client and command helpers
update CHANGELOG
add interface-driven UI components and context cancellation logic

Testing

go test ./... (fails: github.com/klauspost/compress downloads blocked)

https://chatgpt.com/codex/tasks/task_e_686447e438348328b130110af15e4da2

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/devnullvoid/pvetui/pull/13 **Author:** [@devnullvoid](https://github.com/devnullvoid) **Created:** 7/1/2025 **Status:** ✅ Merged **Merged:** 7/2/2025 **Merged by:** [@devnullvoid](https://github.com/devnullvoid) **Base:** `develop` ← **Head:** `codex/review-and-refactor-codebase-for-modularity` --- ### 📝 Commits (5) - [`b066acd`](https://github.com/devnullvoid/pvetui/commit/b066acd6d0fe79eea8fbfe68d6d36497df0144d7) refactor: add UI component interfaces and context - [`f85cf41`](https://github.com/devnullvoid/pvetui/commit/f85cf417f9e62f53ca64b5cb92be91d24ba650e5) fix: update UI interfaces - [`c51cf74`](https://github.com/devnullvoid/pvetui/commit/c51cf74e56623abaf88d5a203e374a53650716ee) fix: align UI component interfaces with tview - [`de076c1`](https://github.com/devnullvoid/pvetui/commit/de076c1fb7d51f85dbe4a9f31c030eb88d0e81d4) fix: compile errors after interface refactor - [`223f856`](https://github.com/devnullvoid/pvetui/commit/223f8563a9247dd6afd4113ba3e033ddaaa92082) Merge branch 'develop' into codex/review-and-refactor-codebase-for-modularity ### 📊 Changes **22 files changed** (+795 additions, -604 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELOG.md` (+4 -0) 📝 `cmd/proxmox-tui/main.go` (+10 -179) ➕ `internal/app/run.go` (+71 -0) ➕ `internal/cache/cache_test.go` (+89 -0) 📝 `internal/commands/commands.go` (+37 -7) 📝 `internal/ssh/client.go` (+16 -3) 📝 `internal/ui/app_runner.go` (+3 -2) 📝 `internal/ui/components/app.go` (+20 -382) ➕ `internal/ui/components/auto_refresh.go` (+308 -0) 📝 `internal/ui/components/cluster_status.go` (+2 -0) 📝 `internal/ui/components/footer.go` (+13 -0) 📝 `internal/ui/components/header.go` (+7 -0) ➕ `internal/ui/components/interfaces.go` (+80 -0) 📝 `internal/ui/components/node_details.go` (+7 -0) 📝 `internal/ui/components/node_list.go` (+8 -0) 📝 `internal/ui/components/refresh.go` (+2 -29) 📝 `internal/ui/components/search.go` (+2 -2) ➕ `internal/ui/components/selection.go` (+30 -0) 📝 `internal/ui/components/tasks_list.go` (+7 -0) 📝 `internal/ui/components/vm_details.go` (+7 -0) _...and 2 more files_ </details> ### 📄 Description ## Summary - add `cache_test.go` covering FileCache operations - refactor UI `App` into smaller files and introduced new thin `main` - implement TODOs in SSH client and command helpers - update CHANGELOG - add interface-driven UI components and context cancellation logic ## Testing - `go test ./...` *(fails: github.com/klauspost/compress downloads blocked)* ------ https://chatgpt.com/codex/tasks/task_e_686447e438348328b130110af15e4da2 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>