mirror of
https://github.com/jpochyla/psst.git
synced 2026-04-27 07:25:52 +03:00
[GH-ISSUE #94] Local files support #70
Labels
No labels
api
bug
build
documentation
duplicate
enhancement
good first issue
help wanted
idea
invalid
linux
lowprio
macos
pull-request
upstream
windows
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/psst#70
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @BitesizedLion on GitHub (Aug 17, 2021).
Original GitHub issue: https://github.com/jpochyla/psst/issues/94
Currently breaks if you click into a Playlist that has local files added.
Error: Failed to read JSON: invalid type: null, expected a string at line 263 column 19@jpochyla commented on GitHub (Aug 18, 2021):
Thanks for the report. In the beginning we'll probably just omit the local tracks, but it should definitely load the rest of the playlist.
@jpochyla commented on GitHub (Aug 18, 2021):
We now skip the local files since
967c077, marking as enhancement, since we might support the actual playback in the future.@Shel-M commented on GitHub (Aug 20, 2021):
Loading a playlist with local files still gave the error when I tried it. It looks like the error is coming from serde/serde_json which can't resolve AlbumLinks because local files return the ID and several more fields as null, which goes unhandled during deserialization. I'll submit a pull request with a fix soon. I got it working on my fork, but it's pretty dirty.
@jpochyla commented on GitHub (Aug 20, 2021):
@AbirV there was indeed another bug, but it should be fixed since yesterday's commit
bbca2bca20.