[GH-ISSUE #94] Local files support #70

Closed
opened 2026-02-28 14:30:24 +03:00 by kerem · 4 comments
Owner

Originally created by @BitesizedLion on GitHub (Aug 17, 2021).
Original GitHub issue: https://github.com/jpochyla/psst/issues/94

Currently breaks if you click into a Playlist that has local files added.

Error: Failed to read JSON: invalid type: null, expected a string at line 263 column 19

Originally created by @BitesizedLion on GitHub (Aug 17, 2021). Original GitHub issue: https://github.com/jpochyla/psst/issues/94 Currently breaks if you click into a Playlist that has local files added. `Error: Failed to read JSON: invalid type: null, expected a string at line 263 column 19`
kerem 2026-02-28 14:30:24 +03:00
Author
Owner

@jpochyla commented on GitHub (Aug 18, 2021):

Thanks for the report. In the beginning we'll probably just omit the local tracks, but it should definitely load the rest of the playlist.

<!-- gh-comment-id:900890062 --> @jpochyla commented on GitHub (Aug 18, 2021): Thanks for the report. In the beginning we'll probably just omit the local tracks, but it should definitely load the rest of the playlist.
Author
Owner

@jpochyla commented on GitHub (Aug 18, 2021):

We now skip the local files since 967c077, marking as enhancement, since we might support the actual playback in the future.

<!-- gh-comment-id:901278683 --> @jpochyla commented on GitHub (Aug 18, 2021): We now skip the local files since 967c077, marking as enhancement, since we might support the actual playback in the future.
Author
Owner

@Shel-M commented on GitHub (Aug 20, 2021):

Loading a playlist with local files still gave the error when I tried it. It looks like the error is coming from serde/serde_json which can't resolve AlbumLinks because local files return the ID and several more fields as null, which goes unhandled during deserialization. I'll submit a pull request with a fix soon. I got it working on my fork, but it's pretty dirty.

<!-- gh-comment-id:902494369 --> @Shel-M commented on GitHub (Aug 20, 2021): Loading a playlist with local files still gave the error when I tried it. It looks like the error is coming from serde/serde_json which can't resolve AlbumLinks because local files return the ID and several more fields as null, which goes unhandled during deserialization. I'll submit a pull request with a fix soon. I got it working on my fork, but it's pretty dirty.
Author
Owner

@jpochyla commented on GitHub (Aug 20, 2021):

@AbirV there was indeed another bug, but it should be fixed since yesterday's commit bbca2bca20.

<!-- gh-comment-id:902516326 --> @jpochyla commented on GitHub (Aug 20, 2021): @AbirV there was indeed another bug, but it should be fixed since yesterday's commit bbca2bca206596fafc2bb180676140ac2ee07500.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/psst#70
No description provided.