[PR #714] [MERGED] Replace custom protobuf handlers with librespot-protocol #677

New issue

Closed

opened 2026-02-28 14:33:51 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 14:33:51 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/jpochyla/psst/pull/714
Author: @Pogodaanton
Created: 12/3/2025
Status: ✅ Merged
Merged: 12/11/2025
Merged by: @jacksongoode

Base: main ← Head: feat/use-librespot-protocol

📝 Commits (2)

77eb3a3 feat(core): Replace custom protobuf handlers with librespot-protocol
bb912d4 Drop psst-protocol completely in favor of librespot

📊 Changes

31 files changed (+118 additions, -5392 deletions)

View changed files

📝 Cargo.lock (+0 -18)
📝 Cargo.toml (+1 -1)
📝 README.md (+0 -1)
📝 psst-core/Cargo.toml (+5 -9)
📝 psst-core/src/cache.rs (+7 -6)
📝 psst-core/src/connection/mod.rs (+69 -50)
📝 psst-core/src/lib.rs (+0 -2)
📝 psst-core/src/metadata.rs (+18 -13)
📝 psst-core/src/player/file.rs (+2 -1)
📝 psst-core/src/player/item.rs (+2 -1)
📝 psst-core/src/session/mercury.rs (+12 -16)
📝 psst-core/src/session/mod.rs (+2 -4)
📝 psst-core/src/util.rs (+0 -29)
➖ psst-protocol/Cargo.toml (+0 -8)
➖ psst-protocol/build.sh (+0 -10)
➖ psst-protocol/proto/authentication.proto (+0 -167)
➖ psst-protocol/proto/keyexchange.proto (+0 -230)
➖ psst-protocol/proto/mercury.proto (+0 -47)
➖ psst-protocol/proto/metadata.proto (+0 -268)
➖ psst-protocol/proto/playlist4changes.proto (+0 -89)

...and 11 more files

📄 Description

In #693 we have introduced librespot-protocol and its direct dependency protobuf to psst-core. The code now uses two different protobuf libraries. This PR aims to reduce it back to one.

I have been unsuccessful at porting new protobuf specs to quick-protobuf. I can't get the bash scripts in psst-protocol running, nor could I reproduce the rust code generation for the already existing protobufs. I tried tackling the problem from the other side instead: Use more of the librespot protobuf code.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/jpochyla/psst/pull/714 **Author:** [@Pogodaanton](https://github.com/Pogodaanton) **Created:** 12/3/2025 **Status:** ✅ Merged **Merged:** 12/11/2025 **Merged by:** [@jacksongoode](https://github.com/jacksongoode) **Base:** `main` ← **Head:** `feat/use-librespot-protocol` --- ### 📝 Commits (2) - [`77eb3a3`](https://github.com/jpochyla/psst/commit/77eb3a3419d0fc9e920544855efd892a0cad32af) feat(core): Replace custom protobuf handlers with librespot-protocol - [`bb912d4`](https://github.com/jpochyla/psst/commit/bb912d40c0c185ef1acf9cc81ff50ee0e47e26a3) Drop psst-protocol completely in favor of librespot ### 📊 Changes **31 files changed** (+118 additions, -5392 deletions) <details> <summary>View changed files</summary> 📝 `Cargo.lock` (+0 -18) 📝 `Cargo.toml` (+1 -1) 📝 `README.md` (+0 -1) 📝 `psst-core/Cargo.toml` (+5 -9) 📝 `psst-core/src/cache.rs` (+7 -6) 📝 `psst-core/src/connection/mod.rs` (+69 -50) 📝 `psst-core/src/lib.rs` (+0 -2) 📝 `psst-core/src/metadata.rs` (+18 -13) 📝 `psst-core/src/player/file.rs` (+2 -1) 📝 `psst-core/src/player/item.rs` (+2 -1) 📝 `psst-core/src/session/mercury.rs` (+12 -16) 📝 `psst-core/src/session/mod.rs` (+2 -4) 📝 `psst-core/src/util.rs` (+0 -29) ➖ `psst-protocol/Cargo.toml` (+0 -8) ➖ `psst-protocol/build.sh` (+0 -10) ➖ `psst-protocol/proto/authentication.proto` (+0 -167) ➖ `psst-protocol/proto/keyexchange.proto` (+0 -230) ➖ `psst-protocol/proto/mercury.proto` (+0 -47) ➖ `psst-protocol/proto/metadata.proto` (+0 -268) ➖ `psst-protocol/proto/playlist4changes.proto` (+0 -89) _...and 11 more files_ </details> ### 📄 Description In #693 we have introduced `librespot-protocol` and its direct dependency `protobuf` to `psst-core`. The code now uses two different protobuf libraries. This PR aims to reduce it back to one. I have been unsuccessful at porting new protobuf specs to `quick-protobuf`. I can't get the bash scripts in `psst-protocol` running, nor could I reproduce the rust code generation for the already existing protobufs. I tried tackling the problem from the other side instead: Use more of the librespot protobuf code. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>