[PR #694] [CLOSED] Fix depreciated reliance on Keymaster tokens #666

New issue

Closed

opened 2026-02-28 14:33:48 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 14:33:48 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/jpochyla/psst/pull/694
Author: @jacksongoode
Created: 9/21/2025
Status: ❌ Closed

Base: main ← Head: auth-login-fix

📝 Commits (3)

308133c This will need to be deeply tested...
0fec6a3 Remove duplicate token methods
2f7c543 More robust expired token auth attempts

📊 Changes

14 files changed (+1128 additions, -603 deletions)

View changed files

📝 Cargo.lock (+591 -480)
📝 psst-core/src/cdn.rs (+79 -42)
📝 psst-core/src/error.rs (+2 -0)
📝 psst-core/src/oauth.rs (+31 -9)
📝 psst-core/src/player/file.rs (+18 -4)
📝 psst-core/src/session/access_token.rs (+24 -5)
📝 psst-core/src/session/mod.rs (+34 -1)
📝 psst-gui/src/controller/session.rs (+6 -0)
📝 psst-gui/src/data/config.rs (+5 -0)
📝 psst-gui/src/data/mod.rs (+1 -1)
📝 psst-gui/src/main.rs (+27 -2)
➕ psst-gui/src/token_utils.rs (+197 -0)
📝 psst-gui/src/ui/preferences.rs (+43 -14)
📝 psst-gui/src/webapi/client.rs (+70 -45)

📄 Description

Make OAuth/PKCE primary
Depreciate Keymaster
Refresh tokens on demand

There are properly a handful of other things here. I didn't want to get rid of all the Keymaster stuff, but it might be that we should eventually do that too. I'd like to follow librespot on this and as I said before this is more of a bandaid. I think these problems ought to be resolved by integrating librespot entirely but that would be a big effort.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/jpochyla/psst/pull/694 **Author:** [@jacksongoode](https://github.com/jacksongoode) **Created:** 9/21/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `auth-login-fix` --- ### 📝 Commits (3) - [`308133c`](https://github.com/jpochyla/psst/commit/308133c86bf17e584da6ed7f0a2803df44d92ea9) This will need to be deeply tested... - [`0fec6a3`](https://github.com/jpochyla/psst/commit/0fec6a3cf718c9d17fff36540c6abdd249d26f81) Remove duplicate token methods - [`2f7c543`](https://github.com/jpochyla/psst/commit/2f7c54397ae03a544d20cbc73c6e34fe976aabbd) More robust expired token auth attempts ### 📊 Changes **14 files changed** (+1128 additions, -603 deletions) <details> <summary>View changed files</summary> 📝 `Cargo.lock` (+591 -480) 📝 `psst-core/src/cdn.rs` (+79 -42) 📝 `psst-core/src/error.rs` (+2 -0) 📝 `psst-core/src/oauth.rs` (+31 -9) 📝 `psst-core/src/player/file.rs` (+18 -4) 📝 `psst-core/src/session/access_token.rs` (+24 -5) 📝 `psst-core/src/session/mod.rs` (+34 -1) 📝 `psst-gui/src/controller/session.rs` (+6 -0) 📝 `psst-gui/src/data/config.rs` (+5 -0) 📝 `psst-gui/src/data/mod.rs` (+1 -1) 📝 `psst-gui/src/main.rs` (+27 -2) ➕ `psst-gui/src/token_utils.rs` (+197 -0) 📝 `psst-gui/src/ui/preferences.rs` (+43 -14) 📝 `psst-gui/src/webapi/client.rs` (+70 -45) </details> ### 📄 Description - Make OAuth/PKCE primary - Depreciate Keymaster - Refresh tokens on demand There are properly a handful of other things here. I didn't want to get rid of all the Keymaster stuff, but it might be that we should eventually do that too. I'd like to follow librespot on this and as I said before this is more of a bandaid. I think these problems ought to be resolved by integrating librespot entirely but that would be a big effort. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>